prometheus/rules
gotjosh c10186eeea
BUGFIX: Mark the rule's restoration process as completed always (#14048)
* BUGFIX: Mark the rule's restoration process as completed always

In https://github.com/prometheus/prometheus/pull/13980 I introduced a change to reduce the number of queries executed when we restore alert statuses.

With this, the querying semantics changed as we now need to go through all series before we enter the alert restoration loop and I missed the fact that exiting early when there are no rules to restore would lead to an incomplete restoration.

An alert being restored is used as a proxy for "we're now ready to write `ALERTS/ALERTS_FOR_SERIES` metrics" so as a result we weren't writing the series if we didn't restore anything the first time around.
---------

Signed-off-by: gotjosh <josue.abreu@gmail.com>
2024-05-03 14:23:46 +01:00
..
fixtures Block until all rules, both sync & async, have completed evaluating 2024-01-29 10:08:41 +01:00
alerting.go Merge pull request #13980 from prometheus/gotjosh/restore-only-with-rule-query 2024-04-30 15:29:21 +01:00
alerting_test.go Use labels.Len() instead of manually counting the labels 2024-04-30 12:25:48 +01:00
group.go BUGFIX: Mark the rule's restoration process as completed always (#14048) 2024-05-03 14:23:46 +01:00
manager.go Allow using alternative PromQL engines for rule evaluation 2024-03-06 14:54:33 +11:00
manager_test.go BUGFIX: Mark the rule's restoration process as completed always (#14048) 2024-05-03 14:23:46 +01:00
origin.go Decouple ruler dependency controller from concurrency controller 2024-02-02 10:06:37 +01:00
origin_test.go Decouple ruler dependency controller from concurrency controller 2024-02-02 10:06:37 +01:00
recording.go Decouple ruler dependency controller from concurrency controller 2024-02-02 10:06:37 +01:00
recording_test.go Tests: use replacement DeepEquals using go-cmp 2024-02-08 19:30:20 +00:00
rule.go Decouple ruler dependency controller from concurrency controller 2024-02-02 10:06:37 +01:00