mirror of
https://github.com/prometheus/prometheus
synced 2024-12-24 07:23:02 +00:00
8fd73b1d28
* Write exemplars to the WAL and send them over remote write. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Update example for exemplars, print data in a more obvious format. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add metrics for remote write of exemplars. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Fix incorrect slices passed to send in remote write. Signed-off-by: Callum Styan <callumstyan@gmail.com> * We need to unregister the new metrics. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments Signed-off-by: Callum Styan <callumstyan@gmail.com> * Order of exemplar append vs write exemplar to WAL needs to change. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Several fixes to prevent sending uninitialized or incorrect samples with an exemplar. Fix dropping exemplar for missing series. Add tests for queue_manager sending exemplars Signed-off-by: Martin Disibio <mdisibio@gmail.com> * Store both samples and exemplars in the same timeseries buffer to remove the alloc when building final request, keep sub-slices in separate buffers for re-use Signed-off-by: Martin Disibio <mdisibio@gmail.com> * Condense sample/exemplar delivery tests to parameterized sub-tests Signed-off-by: Martin Disibio <mdisibio@gmail.com> * Rename test methods for clarity now that they also handle exemplars Signed-off-by: Martin Disibio <mdisibio@gmail.com> * Rename counter variable. Fix instances where metrics were not updated correctly Signed-off-by: Martin Disibio <mdisibio@gmail.com> * Add exemplars to LoadWAL benchmark Signed-off-by: Callum Styan <callumstyan@gmail.com> * last exemplars timestamp metric needs to convert value to seconds with ms precision Signed-off-by: Callum Styan <callumstyan@gmail.com> * Process exemplar records in a separate go routine when loading the WAL. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments related to clarifying comments and variable names. Also refactor sample/exemplar to enqueue prompb types. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Regenerate types proto with comments, update protoc version again. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Put remote write of exemplars behind a feature flag. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address some of Ganesh's review comments. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Move exemplar remote write feature flag to a config file field. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address Bartek's review comments. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Don't allocate exemplar buffers in queue_manager if we're not going to send exemplars over remote write. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add ValidateExemplar function, validate exemplars when appending to head and log them all to WAL before adding them to exemplar storage. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address more reivew comments from Ganesh. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add exemplar total label length check. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address a few last review comments Signed-off-by: Callum Styan <callumstyan@gmail.com> Co-authored-by: Martin Disibio <mdisibio@gmail.com>
294 lines
9.2 KiB
Go
294 lines
9.2 KiB
Go
// Copyright 2020 The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package tsdb
|
|
|
|
import (
|
|
"context"
|
|
"sort"
|
|
"sync"
|
|
"unicode/utf8"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/prometheus/prometheus/pkg/exemplar"
|
|
"github.com/prometheus/prometheus/pkg/labels"
|
|
"github.com/prometheus/prometheus/storage"
|
|
)
|
|
|
|
type CircularExemplarStorage struct {
|
|
exemplarsAppended prometheus.Counter
|
|
exemplarsInStorage prometheus.Gauge
|
|
seriesWithExemplarsInStorage prometheus.Gauge
|
|
lastExemplarsTs prometheus.Gauge
|
|
outOfOrderExemplars prometheus.Counter
|
|
|
|
lock sync.RWMutex
|
|
exemplars []*circularBufferEntry
|
|
nextIndex int
|
|
|
|
// Map of series labels as a string to index entry, which points to the first
|
|
// and last exemplar for the series in the exemplars circular buffer.
|
|
index map[string]*indexEntry
|
|
}
|
|
|
|
type indexEntry struct {
|
|
oldest int
|
|
newest int
|
|
seriesLabels labels.Labels
|
|
}
|
|
|
|
type circularBufferEntry struct {
|
|
exemplar exemplar.Exemplar
|
|
next int
|
|
ref *indexEntry
|
|
}
|
|
|
|
// NewCircularExemplarStorage creates an circular in memory exemplar storage.
|
|
// If we assume the average case 95 bytes per exemplar we can fit 5651272 exemplars in
|
|
// 1GB of extra memory, accounting for the fact that this is heap allocated space.
|
|
// If len < 1, then the exemplar storage is disabled.
|
|
func NewCircularExemplarStorage(len int, reg prometheus.Registerer) (ExemplarStorage, error) {
|
|
if len < 1 {
|
|
return &noopExemplarStorage{}, nil
|
|
}
|
|
c := &CircularExemplarStorage{
|
|
exemplars: make([]*circularBufferEntry, len),
|
|
index: make(map[string]*indexEntry),
|
|
exemplarsAppended: prometheus.NewCounter(prometheus.CounterOpts{
|
|
Name: "prometheus_tsdb_exemplar_exemplars_appended_total",
|
|
Help: "Total number of appended exemplars.",
|
|
}),
|
|
exemplarsInStorage: prometheus.NewGauge(prometheus.GaugeOpts{
|
|
Name: "prometheus_tsdb_exemplar_exemplars_in_storage",
|
|
Help: "Number of exemplars currently in circular storage.",
|
|
}),
|
|
seriesWithExemplarsInStorage: prometheus.NewGauge(prometheus.GaugeOpts{
|
|
Name: "prometheus_tsdb_exemplar_series_with_exemplars_in_storage",
|
|
Help: "Number of series with exemplars currently in circular storage.",
|
|
}),
|
|
lastExemplarsTs: prometheus.NewGauge(prometheus.GaugeOpts{
|
|
Name: "prometheus_tsdb_exemplar_last_exemplars_timestamp_seconds",
|
|
Help: "The timestamp of the oldest exemplar stored in circular storage. Useful to check for what time" +
|
|
"range the current exemplar buffer limit allows. This usually means the last timestamp" +
|
|
"for all exemplars for a typical setup. This is not true though if one of the series timestamp is in future compared to rest series.",
|
|
}),
|
|
outOfOrderExemplars: prometheus.NewCounter(prometheus.CounterOpts{
|
|
Name: "prometheus_tsdb_exemplar_out_of_order_exemplars_total",
|
|
Help: "Total number of out of order exemplar ingestion failed attempts.",
|
|
}),
|
|
}
|
|
if reg != nil {
|
|
reg.MustRegister(
|
|
c.exemplarsAppended,
|
|
c.exemplarsInStorage,
|
|
c.seriesWithExemplarsInStorage,
|
|
c.lastExemplarsTs,
|
|
c.outOfOrderExemplars,
|
|
)
|
|
}
|
|
|
|
return c, nil
|
|
}
|
|
|
|
func (ce *CircularExemplarStorage) Appender() *CircularExemplarStorage {
|
|
return ce
|
|
}
|
|
|
|
func (ce *CircularExemplarStorage) ExemplarQuerier(_ context.Context) (storage.ExemplarQuerier, error) {
|
|
return ce, nil
|
|
}
|
|
|
|
func (ce *CircularExemplarStorage) Querier(_ context.Context) (storage.ExemplarQuerier, error) {
|
|
return ce, nil
|
|
}
|
|
|
|
// Select returns exemplars for a given set of label matchers.
|
|
func (ce *CircularExemplarStorage) Select(start, end int64, matchers ...[]*labels.Matcher) ([]exemplar.QueryResult, error) {
|
|
ret := make([]exemplar.QueryResult, 0)
|
|
|
|
ce.lock.RLock()
|
|
defer ce.lock.RUnlock()
|
|
|
|
// Loop through each index entry, which will point us to first/last exemplar for each series.
|
|
for _, idx := range ce.index {
|
|
var se exemplar.QueryResult
|
|
e := ce.exemplars[idx.oldest]
|
|
if e.exemplar.Ts > end || ce.exemplars[idx.newest].exemplar.Ts < start {
|
|
continue
|
|
}
|
|
if !matchesSomeMatcherSet(idx.seriesLabels, matchers) {
|
|
continue
|
|
}
|
|
se.SeriesLabels = idx.seriesLabels
|
|
|
|
// Loop through all exemplars in the circular buffer for the current series.
|
|
for e.exemplar.Ts <= end {
|
|
if e.exemplar.Ts >= start {
|
|
se.Exemplars = append(se.Exemplars, e.exemplar)
|
|
}
|
|
if e.next == -1 {
|
|
break
|
|
}
|
|
e = ce.exemplars[e.next]
|
|
}
|
|
if len(se.Exemplars) > 0 {
|
|
ret = append(ret, se)
|
|
}
|
|
}
|
|
|
|
sort.Slice(ret, func(i, j int) bool {
|
|
return labels.Compare(ret[i].SeriesLabels, ret[j].SeriesLabels) < 0
|
|
})
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func matchesSomeMatcherSet(lbls labels.Labels, matchers [][]*labels.Matcher) bool {
|
|
Outer:
|
|
for _, ms := range matchers {
|
|
for _, m := range ms {
|
|
if !m.Matches(lbls.Get(m.Name)) {
|
|
continue Outer
|
|
}
|
|
}
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (ce *CircularExemplarStorage) ValidateExemplar(l labels.Labels, e exemplar.Exemplar) error {
|
|
seriesLabels := l.String()
|
|
|
|
// TODO(bwplotka): This lock can lock all scrapers, there might high contention on this on scale.
|
|
// Optimize by moving the lock to be per series (& benchmark it).
|
|
ce.lock.RLock()
|
|
defer ce.lock.RUnlock()
|
|
return ce.validateExemplar(seriesLabels, e, false)
|
|
}
|
|
|
|
// Not thread safe. The append parameters tells us whether this is an external validation, or interal
|
|
// as a reuslt of an AddExemplar call, in which case we should update any relevant metrics.
|
|
func (ce *CircularExemplarStorage) validateExemplar(l string, e exemplar.Exemplar, append bool) error {
|
|
idx, ok := ce.index[l]
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
// Exemplar label length does not include chars involved in text rendering such as quotes
|
|
// equals sign, or commas. See definiton of const ExemplarMaxLabelLength.
|
|
labelSetLen := 0
|
|
for _, l := range e.Labels {
|
|
labelSetLen += utf8.RuneCountInString(l.Name)
|
|
labelSetLen += utf8.RuneCountInString(l.Value)
|
|
|
|
if labelSetLen > exemplar.ExemplarMaxLabelSetLength {
|
|
return storage.ErrExemplarLabelLength
|
|
}
|
|
}
|
|
|
|
// Check for duplicate vs last stored exemplar for this series.
|
|
// NB these are expected, and appending them is a no-op.
|
|
if ce.exemplars[idx.newest].exemplar.Equals(e) {
|
|
return storage.ErrDuplicateExemplar
|
|
}
|
|
|
|
if e.Ts <= ce.exemplars[idx.newest].exemplar.Ts {
|
|
if append {
|
|
ce.outOfOrderExemplars.Inc()
|
|
}
|
|
return storage.ErrOutOfOrderExemplar
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (ce *CircularExemplarStorage) AddExemplar(l labels.Labels, e exemplar.Exemplar) error {
|
|
seriesLabels := l.String()
|
|
|
|
// TODO(bwplotka): This lock can lock all scrapers, there might high contention on this on scale.
|
|
// Optimize by moving the lock to be per series (& benchmark it).
|
|
ce.lock.Lock()
|
|
defer ce.lock.Unlock()
|
|
|
|
err := ce.validateExemplar(seriesLabels, e, true)
|
|
if err != nil {
|
|
if err == storage.ErrDuplicateExemplar {
|
|
// Duplicate exemplar, noop.
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
_, ok := ce.index[seriesLabels]
|
|
if !ok {
|
|
ce.index[seriesLabels] = &indexEntry{oldest: ce.nextIndex, seriesLabels: l}
|
|
} else {
|
|
ce.exemplars[ce.index[seriesLabels].newest].next = ce.nextIndex
|
|
}
|
|
|
|
if prev := ce.exemplars[ce.nextIndex]; prev == nil {
|
|
ce.exemplars[ce.nextIndex] = &circularBufferEntry{}
|
|
} else {
|
|
// There exists exemplar already on this ce.nextIndex entry, drop it, to make place
|
|
// for others.
|
|
prevLabels := prev.ref.seriesLabels.String()
|
|
if prev.next == -1 {
|
|
// Last item for this series, remove index entry.
|
|
delete(ce.index, prevLabels)
|
|
} else {
|
|
ce.index[prevLabels].oldest = prev.next
|
|
}
|
|
}
|
|
|
|
// Default the next value to -1 (which we use to detect that we've iterated through all exemplars for a series in Select)
|
|
// since this is the first exemplar stored for this series.
|
|
ce.exemplars[ce.nextIndex].exemplar = e
|
|
ce.exemplars[ce.nextIndex].next = -1
|
|
ce.exemplars[ce.nextIndex].ref = ce.index[seriesLabels]
|
|
ce.index[seriesLabels].newest = ce.nextIndex
|
|
|
|
ce.nextIndex = (ce.nextIndex + 1) % len(ce.exemplars)
|
|
|
|
ce.exemplarsAppended.Inc()
|
|
ce.seriesWithExemplarsInStorage.Set(float64(len(ce.index)))
|
|
if next := ce.exemplars[ce.nextIndex]; next != nil {
|
|
ce.exemplarsInStorage.Set(float64(len(ce.exemplars)))
|
|
ce.lastExemplarsTs.Set(float64(next.exemplar.Ts) / 1000)
|
|
return nil
|
|
}
|
|
|
|
// We did not yet fill the buffer.
|
|
ce.exemplarsInStorage.Set(float64(ce.nextIndex))
|
|
ce.lastExemplarsTs.Set(float64(ce.exemplars[0].exemplar.Ts) / 1000)
|
|
return nil
|
|
}
|
|
|
|
type noopExemplarStorage struct{}
|
|
|
|
func (noopExemplarStorage) AddExemplar(l labels.Labels, e exemplar.Exemplar) error {
|
|
return nil
|
|
}
|
|
|
|
func (noopExemplarStorage) ValidateExemplar(l labels.Labels, e exemplar.Exemplar) error {
|
|
return nil
|
|
}
|
|
|
|
func (noopExemplarStorage) ExemplarQuerier(context.Context) (storage.ExemplarQuerier, error) {
|
|
return &noopExemplarQuerier{}, nil
|
|
}
|
|
|
|
type noopExemplarQuerier struct{}
|
|
|
|
func (noopExemplarQuerier) Select(_, _ int64, _ ...[]*labels.Matcher) ([]exemplar.QueryResult, error) {
|
|
return nil, nil
|
|
}
|