Go to file
beorn7 4696b46dd5 storage: Fix mixed samples handling in sampleRing
Two issues are fixed here, that lead to the same problem:

1. If `newSampleRing` is called with an unknown ValueType including
   ValueNone, we have initialized the interface buffer (`iBuf`).
   However, we would still use a specialized buffer for the first
   sample, opportunistically assuming that we might still not
   encounter mixed samples and we should go down the more efficient
   road.

2. If the `sampleRing` is `reset`, we leave all buffers alone,
   including `iBuf`, which is generally fine, but not for `iBuf`, see
   below.

In both cases, `iBuf` already contains values, but we will fill one of
the specialized buffers first. Once we then actually encounter mixed
samples, the content of the specialized buffer is copied into `iBuf`
using `append`. That's by itself the right idea because `iBuf` might
be `nil`, and even if not, it might or might not have the right
capacity. However, this approach assumes that `iBuf` is empty, or more
precisely has a length of zero.

This commit makes sure that `iBuf` does not get needlessly initialized
in `newSampleRing` and that it is emptied upon `reset`.

A test case is added to demonstrate both issues above.

Signed-off-by: beorn7 <beorn@grafana.com>
2023-10-31 16:18:09 +01:00
.circleci
.github build(deps): bump actions/upload-artifact from 3.0.0 to 3.1.3 2023-10-01 23:57:36 +00:00
cmd enhance promtool tsdb analyze command (#12869) 2023-10-15 13:47:42 -04:00
config Merge pull request #12816 from slashpai/lightsail 2023-09-08 15:01:35 +02:00
console_libraries
consoles
discovery Merge pull request #11860 from mmorel-35/azure-sdk-for-go 2023-10-15 13:47:42 -04:00
docs Added Azure OAuth support (#12572) 2023-10-04 22:16:36 -04:00
documentation Merge pull request #12981 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/prometheus-0.47.2 2023-10-15 13:47:42 -04:00
model ci(lint): enable errorlint linter on model 2023-09-29 21:11:33 +00:00
notifier ci: use go1.21.0 fmt to make ci happy 2023-08-31 22:01:53 -04:00
plugins Add service discovery for OvhCloud (#10802) 2022-11-03 10:20:09 +01:00
prompb Add created timestamps to prompb (#12936) 2023-10-15 13:47:42 -04:00
promql Remove `NewPossibleNonCounterInfo` and minimise creating empty annotations (#13012) 2023-10-24 17:36:07 +01:00
rules Update exp package (#12650) 2023-09-21 22:53:51 +02:00
scrape scraping: delay creating buffer, to save memory (#12953) 2023-10-09 17:23:53 +01:00
scripts build(deps): bump actions/checkout from 4.0.0 to 4.1.0 in /scripts 2023-10-01 23:43:34 +00:00
storage storage: Fix mixed samples handling in sampleRing 2023-10-31 16:18:09 +01:00
template enable gocritic, unconvert and unused linters 2023-04-13 19:20:22 +00:00
tracing Update dependencies for 2.48 (#12964) 2023-10-15 13:47:42 -04:00
tsdb Remove `NewPossibleNonCounterInfo` and minimise creating empty annotations (#13012) 2023-10-24 17:36:07 +01:00
util Remove `NewPossibleNonCounterInfo` and minimise creating empty annotations (#13012) 2023-10-24 17:36:07 +01:00
web bump version (#13032) 2023-10-27 23:25:56 +02:00
.dockerignore
.gitignore Merge pull request #12057 from hdost/add-parser-documentation 2023-03-06 11:58:41 +01:00
.gitpod.Dockerfile
.gitpod.yml
.golangci.yml ci(lint): enable errorlint linter on model 2023-09-29 21:11:33 +00:00
.promu.yml Update Go version 2023-08-25 17:47:40 +02:00
.yamllint Update sync script. 2023-07-01 11:37:16 +02:00
CHANGELOG.md Release 2.48.0-rc.1 (#13028) 2023-10-25 12:33:03 +01:00
CODE_OF_CONDUCT.md
CONTRIBUTING.md fix some comments 2023-04-25 14:19:16 +08:00
Dockerfile
LICENSE
MAINTAINERS.md Add Jesús Vázquez as a TSDB maintainer (#12222) 2023-04-03 19:41:31 +05:30
Makefile rewrite `which` with `command -v` 2023-06-13 11:59:17 +02:00
Makefile.common Update golangci-lint (#12688) 2023-09-01 12:15:54 +02:00
NOTICE
README.md Add OpenSSF Scorecard badge to README.md 2023-09-29 13:21:05 +02:00
RELEASE.md Volunteer Levi Harrison for release shepherd 2023-10-09 12:21:57 -04:00
SECURITY.md
VERSION bump version (#13032) 2023-10-27 23:25:56 +02:00
go.mod Update dependencies for 2.48 (#12964) 2023-10-15 13:47:42 -04:00
go.sum Update dependencies for 2.48 (#12964) 2023-10-15 13:47:42 -04:00
plugins.yml Add service discovery for OvhCloud (#10802) 2022-11-03 10:20:09 +01:00

README.md

Prometheus
Prometheus

Visit prometheus.io for the full documentation, examples and guides.

CI Docker Repository on Quay Docker Pulls Go Report Card CII Best Practices Gitpod ready-to-code Fuzzing Status OpenSSF Scorecard

Prometheus, a Cloud Native Computing Foundation project, is a systems and service monitoring system. It collects metrics from configured targets at given intervals, evaluates rule expressions, displays the results, and can trigger alerts when specified conditions are observed.

The features that distinguish Prometheus from other metrics and monitoring systems are:

  • A multi-dimensional data model (time series defined by metric name and set of key/value dimensions)
  • PromQL, a powerful and flexible query language to leverage this dimensionality
  • No dependency on distributed storage; single server nodes are autonomous
  • An HTTP pull model for time series collection
  • Pushing time series is supported via an intermediary gateway for batch jobs
  • Targets are discovered via service discovery or static configuration
  • Multiple modes of graphing and dashboarding support
  • Support for hierarchical and horizontal federation

Architecture overview

Architecture overview

Install

There are various ways of installing Prometheus.

Precompiled binaries

Precompiled binaries for released versions are available in the download section on prometheus.io. Using the latest production release binary is the recommended way of installing Prometheus. See the Installing chapter in the documentation for all the details.

Docker images

Docker images are available on Quay.io or Docker Hub.

You can launch a Prometheus container for trying it out with

docker run --name prometheus -d -p 127.0.0.1:9090:9090 prom/prometheus

Prometheus will now be reachable at http://localhost:9090/.

Building from source

To build Prometheus from source code, You need:

Start by cloning the repository:

git clone https://github.com/prometheus/prometheus.git
cd prometheus

You can use the go tool to build and install the prometheus and promtool binaries into your GOPATH:

GO111MODULE=on go install github.com/prometheus/prometheus/cmd/...
prometheus --config.file=your_config.yml

However, when using go install to build Prometheus, Prometheus will expect to be able to read its web assets from local filesystem directories under web/ui/static and web/ui/templates. In order for these assets to be found, you will have to run Prometheus from the root of the cloned repository. Note also that these directories do not include the React UI unless it has been built explicitly using make assets or make build.

An example of the above configuration file can be found here.

You can also build using make build, which will compile in the web assets so that Prometheus can be run from anywhere:

make build
./prometheus --config.file=your_config.yml

The Makefile provides several targets:

  • build: build the prometheus and promtool binaries (includes building and compiling in web assets)
  • test: run the tests
  • test-short: run the short tests
  • format: format the source code
  • vet: check the source code for common errors
  • assets: build the React UI

Service discovery plugins

Prometheus is bundled with many service discovery plugins. When building Prometheus from source, you can edit the plugins.yml file to disable some service discoveries. The file is a yaml-formated list of go import path that will be built into the Prometheus binary.

After you have changed the file, you need to run make build again.

If you are using another method to compile Prometheus, make plugins will generate the plugins file accordingly.

If you add out-of-tree plugins, which we do not endorse at the moment, additional steps might be needed to adjust the go.mod and go.sum files. As always, be extra careful when loading third party code.

Building the Docker image

The make docker target is designed for use in our CI system. You can build a docker image locally with the following commands:

make promu
promu crossbuild -p linux/amd64
make npm_licenses
make common-docker-amd64

Using Prometheus as a Go Library

Remote Write

We are publishing our Remote Write protobuf independently at buf.build.

You can use that as a library:

go get go.buf.build/protocolbuffers/go/prometheus/prometheus

This is experimental.

Prometheus code base

In order to comply with go mod rules, Prometheus release number do not exactly match Go module releases. For the Prometheus v2.y.z releases, we are publishing equivalent v0.y.z tags.

Therefore, a user that would want to use Prometheus v2.35.0 as a library could do:

go get github.com/prometheus/prometheus@v0.35.0

This solution makes it clear that we might break our internal Go APIs between minor user-facing releases, as breaking changes are allowed in major version zero.

React UI Development

For more information on building, running, and developing on the React-based UI, see the React app's README.md.

More information

  • Godoc documentation is available via pkg.go.dev. Due to peculiarities of Go Modules, v2.x.y will be displayed as v0.x.y.
  • See the Community page for how to reach the Prometheus developers and users on various communication channels.

Contributing

Refer to CONTRIBUTING.md

License

Apache License 2.0, see LICENSE.