a60431f3cd
Merge v2.7.1 into master ( #5170 )
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-02-01 09:54:12 +01:00
302148fd69
*: apply gofmt -s
...
Signed-off-by: Matt Layher <mdlayher@gmail.com>
2019-01-16 17:28:14 -05:00
fd3ef6ba34
Add metric rule_group_rules_loaded to get the number of rules loaded ( #5090 )
...
Signed-off-by: Vishnunarayan K I <appukuttancr@gmail.com>
2019-01-13 14:28:07 +00:00
f678e27eb6
*: use latest release of staticcheck ( #5057 )
...
* *: use latest release of staticcheck
It also fixes a couple of things in the code flagged by the additional
checks.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Use official release of staticcheck
Also run 'go list' before staticcheck to avoid failures when downloading packages.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-01-04 14:47:38 +01:00
121603c417
Expose rules.NewGroupMetrics and rules.Metrics. ( #5059 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-03 12:07:06 +00:00
6e08029b56
Move err to be the last return value from storage.Select. ( #5054 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-02 11:10:13 +00:00
de213d4a5e
rule manager: Moved metric registration to custom registerer which is already available. ( #4961 )
...
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
2018-12-28 10:20:29 +00:00
fb8479a677
Variable 'labels' collides with imported package name ( #5012 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-19 09:44:03 +00:00
f0e9196dca
Return warnings on a remote read fail ( #4832 )
...
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
2018-11-30 14:27:12 +00:00
0754e5334b
querier for RestoreForState not closed. ( #4922 )
...
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
2018-11-28 15:25:17 +02:00
c6399296dc
Fix spelling/typos ( #4921 )
...
* Fix spelling/typos
Fix spelling/typos reported by codespell/misspell.
* UK -> US spelling changes.
Signed-off-by: Ben Kochie <superq@gmail.com>
2018-11-27 17:44:29 +01:00
e329cbf673
Add metric prometheus_rule_group_last_evaluation for recording and alerting ( #4852 )
...
* add metric prometheus_rule_group_last_evaluation for recording and alerting
Signed-off-by: Wei Guo <me@imkira.com>
* fix issues from comments
Signed-off-by: Wei Guo <me@imkira.com>
2018-11-27 14:38:13 +08:00
193ebe7e34
Updates to /targets and /rules (scrape duration, last evaluation time) ( #4722 )
...
* Add evaluationTimestamp (Last Evaluation) column to display on /rules
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Add lastScrapeDuration ("Scrape Duration") to display on /targets
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Updates based on Julius' feedback
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Update to set timestamp to when eval started (after eval completes)
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Update /rules to display time since last evaluation
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Re-order Last Eval/Eval Time to be consistent with targets page
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
2018-10-12 18:26:59 +02:00
9bca041285
WIP: keep track of samples per query, set a max # of samples ( #4513 )
...
* keep track of samples per query, set a max # of samples that can be in
memory at once
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2018-10-02 12:59:19 +01:00
5790d23fd8
Unit testing for rules ( #4350 )
...
* Unit testing for rules
* Specifying order of group evaluation in unit tests
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-09-25 17:06:26 +01:00
05726c5ea2
Test template expansion while loading groups ( #4537 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-09-13 13:55:58 +01:00
63ed9d1b70
Send EndsAt along with alerts ( #4550 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-28 16:05:00 +01:00
87f1dad16d
throttle resends of alerts to 1 minute by default ( #4538 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-27 17:41:42 +01:00
f3b7c22827
rules: add comment about lock taking ( #4525 )
...
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2018-08-21 21:30:08 +02:00
c663477688
Fixed TestUpdate in rules/manager_test.go ( #4516 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-08-20 18:21:05 +05:30
8fbe1b5133
Handle a bunch of unchecked errors ( #4461 )
...
There are many more (mostly finalizers like Close/Stop/etc.), but most of
the others seemed like one couldn't do much about them anyway.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-17 17:24:35 +02:00
a0a9e7df91
Fix TestForStateRestore ( #4476 ) ( #4512 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-08-16 22:56:15 +05:30
0b4d22b245
rules/manager: remove a no-longer-relevant comment ( #4503 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2018-08-15 09:33:39 +01:00
11155c7028
Existing alert labels will update based on templates ( #4500 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-15 08:52:08 +01:00
b7e2f407de
rules: Fix double-locking of mutex
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
2018-08-07 07:33:39 -04:00
8bb6e0dd6e
Show rule evaluation errors on rules page ( #4457 )
...
* adding information about the health and errors for Rules
adding Health() and LastError() to the Rule interface. This will allow
us to easily surface information about rules.
Signed-off-by: noqcks <benny@noqcks.io>
* updating rules.html with fields for Rule errors and health state
Signed-off-by: noqcks <benny@noqcks.io>
* fix code comment grammar & access Rule health/error info using a mutex
Signed-off-by: noqcks <benny@noqcks.io>
* s/Errors/Error/ in rules.html to remain consistent with targets.html
Signed-off-by: noqcks <benny@noqcks.io>
* adding periods to code comments in reporting/alerting
Signed-off-by: noqcks <benny@noqcks.io>
* putting health/error below mutex in struct field
Signed-off-by: noqcks <benny@noqcks.io>
2018-08-07 00:33:45 +02:00
2b8fc062a8
rules: HTML-escape rule YAML marshal errors ( #4464 )
...
This was pointed out by `gosec`.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-05 14:01:51 +02:00
90521a65f8
Remove error return value from NotifyFunc() ( #4459 )
...
It's always nil and we also forgot to check it.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-04 21:31:12 +02:00
f1db699dff
Persist alert 'for' state across restarts ( #4061 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-08-02 11:18:24 +01:00
71fafad099
api/v1: Coninue work exposing rules and alerts
...
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
2018-07-30 15:31:51 +02:00
31f8ca0dfb
api v1 alerts/rules json endpoint
...
Signed-off-by: mg03 <mgeng03@gmail.com>
2018-07-30 15:29:44 +02:00
afdb66dfac
Expose Group.CopyState() ( #4304 )
...
This makes the `rules` package more useful to projects that use
Prometheus as a library.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2018-07-18 15:14:38 +02:00
9e3171f6e3
rules: Minor naming/comment cleanups ( #4328 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-07-18 04:54:33 +01:00
2bd510a63e
Make TestUpdate() do some work ( #4306 )
...
Previously it would set no preconditions and check no postconditions,
as the `groups` member was empty.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2018-06-22 15:21:04 +01:00
9dc763cc03
Run rule evaluation with timestamps precisely evaluation_interval apart ( #4201 )
...
* Run rule evaluation with timestamps precisely evaluation_interval apart from one another.
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-06-01 15:23:07 +01:00
464e747f1e
fix some comments typos ( #4059 )
2018-04-08 10:51:54 +01:00
93494d8b7e
Add an OpenTracing span for each rule ( #4027 )
...
* Add an OpenTracing span for each rule
So that tags and child spans can be traced back to the rule that they
refer to.
2018-03-30 21:29:19 +01:00
ec8e4d8a7c
all: remove unnecessary type conversions ( #3992 )
...
excep promql due to not to create conflict with #3966 .
2018-03-21 09:25:22 +00:00
58e2a31db8
Cleans up test by removing unused function ( #3969 )
2018-03-15 08:59:19 +00:00
ffa673f7d8
General simplifications ( #3887 )
...
Another try as in #1516
2018-02-26 07:58:10 +00:00
7ccd4b39b8
*: implement query params
...
This adds a parameter to the storage selection interface which allows
query engine(s) to pass information about the operations surrounding a
data selection.
This can for example be used by remote storage backends to infer the
correct downsampling aggregates that need to be provided.
2018-02-13 12:17:22 +01:00
81c0ab69e0
Don't reset FiredAt for inactive alerts
...
Otherwise AlertManager receives resolved alerts where StartsAt is zero which
fails the validation.
2018-01-22 17:17:33 +01:00
30b4439bbd
Remove rule_type label from rule metrics.
...
This is not really needed now that we have rule groups
to distinguish rules.
2017-12-04 11:44:38 +00:00
b97f4cf48c
Add metrics for rule group interval and last duration.
2017-12-04 11:44:38 +00:00
0a42a9fc8f
Copy over rule group duration on reload.
...
This is currently getting lost, this will soon be in a metric and we
don't want it dropping to 0 on every reload.
2017-12-04 11:44:38 +00:00
aa370fa568
Clarify metric names around rule groups.
...
Make it clear they're about overall rule groups.
2017-12-04 11:44:38 +00:00
62461379b7
rules: decouple notifier packages
...
The dependency on the notifier packages caused a transitive dependency
on discovery and with that all client libraries our service discovery
uses.
2017-11-27 16:38:14 +01:00
4d964a0a0d
rules: make glob expansion a concern of main
2017-11-24 08:22:57 +01:00
bd9f7460eb
rules: remove config package dependency
2017-11-24 07:57:54 +01:00
2d0e3746ac
rules: remove dependency on promql.Engine
2017-11-24 07:57:54 +01:00
Simon Pasquier
Matt Layher
Vishnunarayan K I
Tom Wilkie
Bartek Płotka
AixesHunter
mknapphrt
Krasi Georgiev
Ben Kochie
Wei Guo
Will Hegedus
Callum Styan
Ganesh Vernekar
Chris Marchbanks
Goutham Veeramachaneni
Julius Volz
Julien Pivotto
Fabian Reinartz
Benji Visser
Max Leonard Inden
mg03
Bryan Boreham
Alin Sinpalean
Mario Trangoni
ferhat elmas
Warren Fernandes
Fabian Reinartz
Brian Brazil