Commit Graph

692 Commits

Author SHA1 Message Date
Goutham Veeramachaneni
41fd9c66ef
Close the retention blocks before deleting them.
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-11-23 18:57:10 +05:30
Fabian Reinartz
684be3f35e
Merge pull request #206 from prometheus/typez
Add explicit error to Querier.Select
2017-11-23 10:54:26 +01:00
Goutham Veeramachaneni
1fc94a02d1
Don't retry failed compactions.
Fixes prometheus/prometheus#3487

Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-11-23 15:16:20 +05:30
Goutham Veeramachaneni
1627a47640
A copy is being assigned newChunk not the original
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-11-22 17:58:06 +05:30
Fabian Reinartz
a031cf7424 Return ULID in Compactor 2017-11-14 15:25:30 +01:00
Goutham Veeramachaneni
a00d700d48
Merge pull request #200 from jaxi/build_on_smartos
Ensure tsdb can be built on SmartOS/Illumos/Solaris
2017-11-14 19:28:25 +05:30
Fabian Reinartz
f1512a368a Expose ChunkSeriesSet and lookups methods. 2017-11-13 14:02:32 +01:00
Fabian Reinartz
3ef4326114 Refactor tombstone reader types 2017-11-13 13:38:07 +01:00
Fabian Reinartz
e5ce2bef43 Add explicit error to Querier.Select
This has been a frequent source of debugging pain since errors are
potentially delayed to a much later point. They bubble up in an
unrelated execution path.
2017-11-13 12:16:58 +01:00
Goutham Veeramachaneni
032413caf0
Merge pull request #205 from opsnull/master
fix typing
2017-11-13 10:52:10 +05:30
zhangjun3
65e6b79a7c fix typing 2017-11-13 13:10:23 +08:00
Julius Volz
9703325901
Merge pull request #204 from prometheus/fix-wal-closing
Close WAL when closing the DB
2017-11-11 16:02:58 +01:00
Julius Volz
1dad3370fd Close WAL when closing the DB
Also, the `wal` field of the `DB` was not used anywhere, so this removes
it.
2017-11-11 14:56:23 +01:00
Fabian Reinartz
1d08a00d63
Merge pull request #203 from prometheus/absbytes
Generalize index and chunk readers
2017-11-10 14:10:41 +00:00
Fabian Reinartz
ac5bd71d8f Doc fixes 2017-11-10 14:10:20 +00:00
Fabian Reinartz
d578b10d5c chunk: make reader accept abstract ByteSlice 2017-11-10 10:38:22 +00:00
Fabian Reinartz
b7c3cfecbf index: abstract ByteSlice and adjust indexReader
This replaces the builtin byte slice with an interface for the index
reader. This allows the complex decoding of the index file format
to be used against more generalized implementations.
2017-11-09 17:38:32 +00:00
Fabian Reinartz
c354d6bd59 index: simplify checksum validation 2017-11-09 15:58:36 +00:00
Fabian Reinartz
798f2bdb0a
Merge pull request #189 from sunhay/checksum-checks
Index checksum validation on reads
2017-11-09 15:35:09 +00:00
Fabian Reinartz
b4d093a8a7
Merge pull request #201 from prometheus/grobie/fix-typo-in-metric
Fix typo in prometheus_tsdb_reloads_failures_total description
2017-11-09 13:27:12 +00:00
Tobias Schmidt
5170198276 Fix typo in prometheus_tsdb_reloads_failures_total description 2017-11-09 14:25:27 +01:00
Jingkai He
bfadf72d3f
Ensure tsdb can be built on SmartOS/Illumos/Solaris
At the moment tsdb cannot be built on Illumos/Solaris due to

- An exclude tag against Solaris is added in db_unix.go
- We use built-in syscall package, which doesn't have nmmap and munmap support

This PR supports build on Illumos/Solaris by remove the Solaris exclude tag in db_unix.go
At the same time use golang.org/x/sys/unix package instead of syscall package, since it has Solaris nmmap and munmap implementation.
2017-11-08 23:32:35 +00:00
Fabian Reinartz
1bacdf8e33
Merge pull request #198 from dswarbrick/master
Use Go 1.9 math/bits funcs for counting leading / trailing zeros
2017-11-08 23:31:49 +00:00
Daniel Swarbrick
57cefba0d5 Move to Go 1.9 2017-11-08 23:26:51 +01:00
Daniel Swarbrick
0585ab3fcd Use Go 1.9 math/bits implementation for counting leading / trailing zeros 2017-11-08 23:18:33 +01:00
Fabian Reinartz
7337c6a513
Merge pull request #196 from prometheus/grobie/fix-metric-prefix
Fix missing prefix of tsdb_wal_* metrics
2017-11-08 13:59:39 +00:00
Tobias Schmidt
6027af95ca Fix missing prefix of tsdb_wal_* metrics 2017-11-08 14:58:03 +01:00
Fabian Reinartz
706602daed
Merge pull request #195 from prometheus/delblocks
db: delete old blocks during reload
2017-11-04 08:45:56 +01:00
Fabian Reinartz
d226411a2a db: delete old blocks during reload
Windows requires blocks to be closed before deleting their directories.
This adds a set of deleteable blocks to reload(), which then deletes
them without causing disruption to querying.
2017-11-03 20:41:24 +01:00
Fabian Reinartz
296faccf2f
Merge pull request #193 from ranbochen/fix-#191
Fix #191
2017-11-03 20:20:01 +01:00
Nipun Talukdar
791a2dda4d Fixed a problem of adding padding of 4 zero bytes in some cases (#194)
* Fixed a problem of adding padding of 4 zero bytes in some cases

* Incorporated review comments
2017-11-03 20:16:19 +01:00
Fabian Reinartz
b1df857819
Merge pull request #190 from prometheus/walsync
wal: synchronize background operations
2017-11-01 18:11:22 +01:00
Fabian Reinartz
a993f0ccc0
Fix typo 2017-11-01 18:11:09 +01:00
Your Name
4a4a706234 close blocks which will be remove 2017-11-02 00:30:19 +08:00
ranbochen
a27cf34a36 fix bugs on platform windows to pass all test case. (#192)
* fix bugs on platform windows to pass all test case.

* fix bugs on platform windows to pass all test case

* clean up codes
2017-10-31 15:37:41 +01:00
ranbo chen
19340a382d clean up codes 2017-10-31 21:08:56 +08:00
ranbo chen
90de381cdb fix bugs on platform windows to pass all test case 2017-10-31 20:38:32 +08:00
ranbo chen
b82b2d0c1b fix bugs on platform windows to pass all test case. 2017-10-31 20:07:29 +08:00
Fabian Reinartz
8aedb7671e wal: synchronize background operations
This adds an actor channel and thereby serializes all background
operations through the run() method.
Fixes an existing race.
2017-10-30 09:50:21 +01:00
Sunny Klair
aecac3b521 Resuse single CRC for index checksum validation 2017-10-27 12:29:59 -04:00
Sunny Klair
b65dd43c5b Validate index series/postings/symbol table checksums on read 2017-10-26 15:34:31 -04:00
Sunny Klair
ab02ea4de4 Validate index offset table checksums on read 2017-10-26 13:48:31 -04:00
Sunny Klair
4fdf9b195c Validate index TOC checksum on read 2017-10-25 18:12:13 -04:00
Oren Shomron
6ca5e52b69 Typo in prometheus_tsdb_head_samples_appended_total description (#188) 2017-10-25 19:12:18 +01:00
Fabian Reinartz
5d28c849c7 Merge pull request #187 from prometheus/cutchunk
Ensure near-empty chunks end at correct boundary
2017-10-25 16:52:11 +02:00
Fabian Reinartz
82796db37b Ensure near-empty chunks end at correct boundary
We were determining a chunk's end time once it was one quarter full to
compute it so all chunks have uniform number of samples.
This accidentally skipped the case where series started near the end of
a chunk range/block and never reached that threshold. As a result they
got persisted but were continued across the range.

This resulted in corrupted persisted data.
2017-10-25 09:51:55 +02:00
Fabian Reinartz
d109149d17 Merge pull request #186 from prometheus/closeallblocks
Ensure readers are closed on setup failure.
2017-10-25 09:31:06 +02:00
Fabian Reinartz
c93162c751 Merge pull request #185 from prometheus/walslice
Limit WAL sample processing batch size
2017-10-25 09:30:52 +02:00
Fabian Reinartz
820bd8b170 Merge pull request #181 from prometheus/gcchunk
Fix dangling chunk reference panic
2017-10-25 09:30:16 +02:00
Fabian Reinartz
6ecdaa5314 Merge pull request #183 from prometheus/walbrokensegment
Truncate segments on broken header
2017-10-25 09:27:44 +02:00