b987afa7ef
labels: simplify call to get Labels from Builder
...
It took a `Labels` where the memory could be re-used, but in practice
this hardly ever benefitted. Especially after converting `relabel.Process`
to `relabel.ProcessBuilder`.
Comparing the parameter to `nil` was a bug; `EmptyLabels` is not `nil`
so the slice was reallocated multiple times by `append`.
Lastly `Builder.Labels()` now estimates that the final size will depend
on labels added and deleted.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2023-03-22 17:05:20 +00:00
bf2c827d91
Update package cmd/promtool for new labels.Labels type
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-12-19 15:22:09 +00:00
8b863c42dd
Optimise relabeling by re-using memory ( #11147 )
...
* model/relabel: Add benchmark
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* model/relabel: re-use Builder across relabels
Saves memory allocations.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* labels.Builder: allow re-use of result slice
This reduces memory allocations where the caller has a suitable slice available.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* model/relabel: re-use source values slice
To reduce memory allocations.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* Unwind one change causing test failures
Restore original behaviour in PopulateLabels, where we must not overwrite the input set.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* relabel: simplify values optimisation
Use a stack-based array for up to 16 source labels, which will be the
vast majority of cases.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
* lint
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2022-08-19 15:27:52 +05:30
fa9bc5184a
Update and fix interface ( #11131 )
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2022-08-10 10:14:52 +02:00
36eee11434
refactor (package cmd): move from github.com/pkg/errors to 'errors' and 'fmt' packages ( #10733 )
...
Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
2022-05-24 16:58:59 +10:00
83a2e52bc2
Add SyncForState Implementation for Ruler HA ( #10070 )
...
* continuously syncing activeAt for alerts
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* add import
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Refactor SyncForState and add unit tests
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Format code
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Add hook for syncForState
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix go lint
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Refactor syncForState override implementation
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Add syncForState override func as argument to Update()
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix go formatting
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix circleci test errors
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Remove overrideFunc as argument to run()
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* remove the syncForState
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* use the override function to decide if need to replace the activeAt or not
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix test case
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix format
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* Trigger build
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fixing comments
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* return the result of map of alerts instead of single one
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* upper case the QueryforStateSeries
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* use a more generic rule group post process function type
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix indentation
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix gofmt
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix lint
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fixing naming
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix comments
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* add the lastEvalTimestamp as parameter
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fmt
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* change funcType to func
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Co-authored-by: Yijie Qin <qinyijie@amazon.com>
Co-authored-by: Yijie Qin <63399121+qinxx108@users.noreply.github.com>
2022-03-29 02:16:46 +02:00
a4317bf0ec
Run gofumpt on all files ( #10392 )
...
* Run gofumpt on all files
Getting golangci-lint errors when building on my laptop, possibly because I have newer version of gofumpt then what it was formatted with.
Run gofumpt -w -extra on all files as it will be needed in the future anyway.
* Update golangci-lint to v1.44.2
v1.44.0 upgraded gofumpt so bumping version in CI will help keep formatting correct for everyone
* Address golangci-lint error
Getting 'error-strings: error strings should not be capitalized or end with punctuation or a newline' from revive here.
Drop new line.
Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
2022-03-03 17:21:05 +01:00
c954cd9d1d
Move packages out of deprecated pkg directory
...
This creates a new `model` directory and moves all data-model related
packages over there:
exemplar labels relabel rulefmt textparse timestamp value
All the others are more or less utilities and have been moved to `util`:
gate logging modetimevfs pool runtime
Signed-off-by: beorn7 <beorn@grafana.com>
2021-11-09 08:03:10 +01:00
b7bdf6fab2
Fix imports formatting
...
According to
2829908806 (r58457095)
2021-11-02 19:52:34 +01:00
73255e15f6
Address golint failures from revive
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-10-23 00:53:11 +02:00
97b0738895
add --max-block-duration in promtool create-blocks-from rules ( #9511 )
...
* support maxBlockDuration for promtool tsdb create-blocks-from rules
Fixes #9465
Signed-off-by: Will Tran <will@autonomic.ai>
* don't hardcode 2h as the default block size in rules test
Signed-off-by: Will Tran <will@autonomic.ai>
2021-10-21 23:28:37 +02:00
f8372bc6b9
backfill: Apply rule labels after query labels
...
Fix #9419
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-10-18 01:04:13 +02:00
bd217c58a7
Backfill: Do not query after --end ( #9340 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-09-15 16:02:41 +02:00
1ea774f184
Merge pull request #9339 from roidelapluie/remove-double-align
...
backfill: Do not align the start of the group since we align every rule.
2021-09-14 23:46:25 +02:00
691ce066fb
backfill: Do not align the start of the group since we align every rule.
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2021-09-14 23:13:06 +02:00
b0a21f9eab
rm overlap, add label builder to fix name bug
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-09-13 10:32:08 -07:00
ded95ff434
Fix new rule importer message
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-09-06 22:19:29 -04:00
b5f6f8fb36
Switched to go-kit/log
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-06-11 12:28:36 -04:00
17ea8d006a
Added external URL access
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-05-30 23:35:26 -04:00
57bc2e94e2
typos correct
...
Signed-off-by: cuirunxing-hub <cuirunxing@inspur.com>
2021-04-02 09:03:00 +08:00
896c828bb5
close writer after flush
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-29 06:45:12 -07:00
d89a1d999f
add log with start/end times, close blocks before end of func
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-28 12:13:58 -07:00
8de4da3716
add changes per comments, fix tests
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-20 12:38:30 -07:00
e3a8132bb3
fix block alignment, add sample alignment
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-15 12:44:58 -07:00
7c26642460
add block alignment and write in 2 hr blocks
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-14 10:10:55 -07:00
9fc53b7edf
fix appender.Add -> appender.Append
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2021-03-01 05:49:49 -08:00
e32e4fcc53
fix unit test
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-30 11:02:45 -08:00
cec3515fa3
fix linter
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-30 08:17:51 -08:00
2e9946e4d7
add test
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-28 07:58:33 -08:00
ee85c22adb
flush samples to disk every 5k samples
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-26 08:30:06 -08:00
19dee0a569
add name and labels to metric, eval all rules for each block
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-22 14:24:38 -08:00
75654715d3
fix panics
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-11-01 07:54:04 -08:00
61c9a89120
use milliseconds for blocksize
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-10-31 07:11:54 -07:00
6980bcf671
unexport backfiller
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-10-31 06:40:56 -07:00
3ed6457dd4
use blockwriter, rm multiwriter code
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-10-31 06:32:07 -07:00
2e526cf2a7
add output dir parameter
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-09-13 08:38:32 -07:00
dfa510086b
add alignment, mv rule importer to promtool dir, add queryRange
...
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
2020-09-13 08:07:59 -07:00
Bryan Boreham
Levi Harrison
Matthieu MOREL
Wilbert Guo
Łukasz Mierzwa
beorn7
Mateusz Gozdek
Julien Pivotto
Will Tran
jessicagreben
cuirunxing-hub