0d94cdf107
rules: remove classic UI code ( #10730 )
...
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2022-05-23 16:21:50 +02:00
83a2e52bc2
Add SyncForState Implementation for Ruler HA ( #10070 )
...
* continuously syncing activeAt for alerts
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* add import
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Refactor SyncForState and add unit tests
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Format code
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* Add hook for syncForState
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix go lint
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Refactor syncForState override implementation
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Add syncForState override func as argument to Update()
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix go formatting
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Fix circleci test errors
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
Remove overrideFunc as argument to run()
Signed-off-by: Wilbert Guo <wilbeguo@amazon.com>
* remove the syncForState
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* use the override function to decide if need to replace the activeAt or not
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix test case
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix format
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* Trigger build
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fixing comments
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* return the result of map of alerts instead of single one
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* upper case the QueryforStateSeries
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* use a more generic rule group post process function type
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix indentation
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix gofmt
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix lint
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fixing naming
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fix comments
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* add the lastEvalTimestamp as parameter
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* fmt
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* change funcType to func
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Co-authored-by: Yijie Qin <qinyijie@amazon.com>
Co-authored-by: Yijie Qin <63399121+qinxx108@users.noreply.github.com>
2022-03-29 02:16:46 +02:00
c954cd9d1d
Move packages out of deprecated pkg directory
...
This creates a new `model` directory and moves all data-model related
packages over there:
exemplar labels relabel rulefmt textparse timestamp value
All the others are more or less utilities and have been moved to `util`:
gate logging modetimevfs pool runtime
Signed-off-by: beorn7 <beorn@grafana.com>
2021-11-09 08:03:10 +01:00
6fce45838a
Add access function for restoration state of alerting rule ( #9665 )
2021-11-05 18:26:29 -04:00
1a6c2283a3
Format Go source files using 'gofumpt -w -s -extra'
...
Part of #9557
Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
2021-11-02 19:52:34 +01:00
d81bbe154d
Rule alerts/series limit updates ( #9541 )
...
* Add docs and do not limit inactive alerts.
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-10-21 23:14:17 +02:00
dc2f1993d8
Limit number of alerts or series produced by a rule ( #9260 )
...
* Add limit to rules
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-09-15 09:48:26 +02:00
049b4f4f13
Support customization of template options in TemplateExpander ( #9290 )
...
Signed-off-by: George Robinson <george.robinson@grafana.com>
2021-09-13 17:19:08 +05:30
8c29046ab2
Remove unneeded state modifications
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-08-20 16:42:31 -04:00
b5f6f8fb36
Switched to go-kit/log
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-06-11 12:28:36 -04:00
17ea8d006a
Added external URL access
...
Signed-off-by: Levi Harrison <git@leviharrison.dev>
2021-05-30 23:35:26 -04:00
4e5b1722b3
Move away from testutil, refactor imports ( #8087 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-10-22 11:00:08 +02:00
a69a8b931f
rules: fix bug for unknown alert state. ( #7599 )
...
Signed-off-by: johncming <johncming@yahoo.com>
2020-07-17 08:39:15 +01:00
5368066b58
Give a bit more slack for alertmanager send failures. ( #7228 )
...
Fixes #5277
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2020-05-09 05:37:46 +01:00
20b1f596f6
Fix build errors in rest of prometheus
...
Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
2020-02-17 16:09:23 +01:00
0e912faf4f
rules: Cleanup unused function alert.Duration ( #6734 )
...
The function HoldDuration and Duration did the exact same thing.
Let's only keep HoldDuration() as Duration() is more confusing.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2020-02-01 07:31:37 +00:00
2d7c8069d0
Check that rules don't contain metrics with the same labelset ( #6469 )
...
Closes #5529
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
2019-12-18 12:29:35 +00:00
5c2c9a03e9
fix word 'consequentally' to 'consequently' ( #5827 )
...
Signed-off-by: czm <zhongming.chang@daocloud.io>
2019-08-03 14:56:58 +01:00
38d518c0fe
Rework #5009 after comments
...
Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>
2019-04-17 01:40:10 +02:00
335a34486e
Add external labels to template expansion
...
This affects the expansion of templates in alert labels and
annotations and console templates.
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
2019-04-17 01:40:10 +02:00
8fdfa8abea
refine error handling in prometheus ( #5388 )
...
i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors.
ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives.
iii) Does away with the use of fmt package for errors in favour of pkg/errors
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
2019-03-26 00:01:12 +01:00
f678e27eb6
*: use latest release of staticcheck ( #5057 )
...
* *: use latest release of staticcheck
It also fixes a couple of things in the code flagged by the additional
checks.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Use official release of staticcheck
Also run 'go list' before staticcheck to avoid failures when downloading packages.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-01-04 14:47:38 +01:00
fb8479a677
Variable 'labels' collides with imported package name ( #5012 )
...
Signed-off-by: aixeshunter <aixeshunter@gmail.com>
2018-12-19 09:44:03 +00:00
c6399296dc
Fix spelling/typos ( #4921 )
...
* Fix spelling/typos
Fix spelling/typos reported by codespell/misspell.
* UK -> US spelling changes.
Signed-off-by: Ben Kochie <superq@gmail.com>
2018-11-27 17:44:29 +01:00
193ebe7e34
Updates to /targets and /rules (scrape duration, last evaluation time) ( #4722 )
...
* Add evaluationTimestamp (Last Evaluation) column to display on /rules
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Add lastScrapeDuration ("Scrape Duration") to display on /targets
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Updates based on Julius' feedback
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Update to set timestamp to when eval started (after eval completes)
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Update /rules to display time since last evaluation
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
* Re-order Last Eval/Eval Time to be consistent with targets page
Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>
2018-10-12 18:26:59 +02:00
05726c5ea2
Test template expansion while loading groups ( #4537 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-09-13 13:55:58 +01:00
63ed9d1b70
Send EndsAt along with alerts ( #4550 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-28 16:05:00 +01:00
87f1dad16d
throttle resends of alerts to 1 minute by default ( #4538 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-27 17:41:42 +01:00
f3b7c22827
rules: add comment about lock taking ( #4525 )
...
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2018-08-21 21:30:08 +02:00
11155c7028
Existing alert labels will update based on templates ( #4500 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-08-15 08:52:08 +01:00
b7e2f407de
rules: Fix double-locking of mutex
...
Signed-off-by: Fabian Reinartz <freinartz@google.com>
2018-08-07 07:33:39 -04:00
8bb6e0dd6e
Show rule evaluation errors on rules page ( #4457 )
...
* adding information about the health and errors for Rules
adding Health() and LastError() to the Rule interface. This will allow
us to easily surface information about rules.
Signed-off-by: noqcks <benny@noqcks.io>
* updating rules.html with fields for Rule errors and health state
Signed-off-by: noqcks <benny@noqcks.io>
* fix code comment grammar & access Rule health/error info using a mutex
Signed-off-by: noqcks <benny@noqcks.io>
* s/Errors/Error/ in rules.html to remain consistent with targets.html
Signed-off-by: noqcks <benny@noqcks.io>
* adding periods to code comments in reporting/alerting
Signed-off-by: noqcks <benny@noqcks.io>
* putting health/error below mutex in struct field
Signed-off-by: noqcks <benny@noqcks.io>
2018-08-07 00:33:45 +02:00
2b8fc062a8
rules: HTML-escape rule YAML marshal errors ( #4464 )
...
This was pointed out by `gosec`.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-05 14:01:51 +02:00
f1db699dff
Persist alert 'for' state across restarts ( #4061 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-08-02 11:18:24 +01:00
71fafad099
api/v1: Coninue work exposing rules and alerts
...
Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
2018-07-30 15:31:51 +02:00
31f8ca0dfb
api v1 alerts/rules json endpoint
...
Signed-off-by: mg03 <mgeng03@gmail.com>
2018-07-30 15:29:44 +02:00
9e3171f6e3
rules: Minor naming/comment cleanups ( #4328 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-07-18 04:54:33 +01:00
ec8e4d8a7c
all: remove unnecessary type conversions ( #3992 )
...
excep promql due to not to create conflict with #3966 .
2018-03-21 09:25:22 +00:00
81c0ab69e0
Don't reset FiredAt for inactive alerts
...
Otherwise AlertManager receives resolved alerts where StartsAt is zero which
fails the validation.
2018-01-22 17:17:33 +01:00
62461379b7
rules: decouple notifier packages
...
The dependency on the notifier packages caused a transitive dependency
on discovery and with that all client libraries our service discovery
uses.
2017-11-27 16:38:14 +01:00
2d0e3746ac
rules: remove dependency on promql.Engine
2017-11-24 07:57:54 +01:00
a880c86375
Fix unexported method on exported interface.
...
Also move to model.Duration
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-11-23 19:13:57 +05:30
55aaece116
Add rule evaluation time
2017-11-22 15:22:02 +00:00
099df0c5f0
Migrate "golang.org/x/net/context" -> "context" ( #3333 )
...
In some places, where ctxhttp or gRPC are concerned, we still need to use the
old contexts.
2017-10-24 21:21:42 -07:00
2d0b8e8b94
Merge branch 'master' into dev-2.0
2017-10-05 13:09:18 +02:00
c2e9a151ab
Make all rule links link to the "Console" tab rather than "Graph"
...
Clicking on a rule, either the name or the expression, opens the rule
result (or the corresponding expression, repsectively) in the
expression browser. This should by default happen in the console tab,
as, more often than not, displaying it in the graph tab runs into a
timeout.
2017-09-21 18:28:00 +02:00
d21f149745
*: migrate to go-kit/log
2017-09-08 22:01:51 +05:30
e1fc9dc78d
Move /rules to new format ( #2901 )
...
Fixes #2891
Signed-off-by: Goutham Veeramachaneni <goutham@boomerangcommerce.com>
2017-07-08 11:38:02 +02:00
507790a357
Rework logging to use explicitly passed logger
...
Mostly cleaned up the global logger use. Still some uses in discovery
package.
Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
2017-06-16 15:52:44 +05:30
dcea3e4773
Don't append a 0 when alert is no longer pending/firing
...
With staleness we no longer need this behaviour.
2017-05-24 13:52:45 +01:00
Julien Pivotto
Wilbert Guo
beorn7
Yijie Qin
Mateusz Gozdek
Levi Harrison
George Robinson
johncming
Brian Brazil
Tobias Guggenmos
AllenZMC
Bjoern Rabenstein
Sylvain Rabot
Tariq Ibrahim
Simon Pasquier
AixesHunter
Ben Kochie
Will Hegedus
Ganesh Vernekar
Chris Marchbanks
Goutham Veeramachaneni
Fabian Reinartz
Benji Visser
Julius Volz
Max Leonard Inden
mg03
ferhat elmas
Fabian Reinartz
Goutham Veeramachaneni
conorbroderick
beorn7