Brian Brazil
858c363e94
Fix panic when aggregator param is not a literal.
...
The return value for checkForSeriesSetExpansion
is always nil, simplify.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-03-04 12:00:05 +00:00
Nguyen Hai Truong
aed9ea144a
Remove duplicated words in comments
...
Although it is spelling mistakes, it might make an affects
while reading.
Co-Authored-By: Kim Bao Long longkb@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-20 17:41:02 -08:00
Tariq Ibrahim
a2a6e24f9f
show list of offending labels in the error message in many-to-many scenarios ( #5189 )
...
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
2019-02-09 10:17:52 +01:00
JoeWrightss
e158c53fa9
Fix some typos in comment ( #5175 )
...
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-02-01 14:35:32 +00:00
Brian Brazil
c66aeb3fff
In histogram_quantile merge buckets with equivalent le values ( #5158 )
...
This makes things generally more resilient, and will
help with OpenMetrics transitions (and inconsistencies).
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2019-02-01 10:22:44 +00:00
Bryan Boreham
8841692a63
Use the context associated with the inner evaluation span ( #5130 )
...
Signed-off-by: Bryan Boreham <bryan@weave.works>
2019-01-28 18:33:30 +00:00
Matt Layher
c44cd7e166
Merge pull request #5102 from prometheus/mdl-gofmt
...
*: apply gofmt -s
2019-01-16 19:12:43 -05:00
Matt Layher
302148fd69
*: apply gofmt -s
...
Signed-off-by: Matt Layher <mdlayher@gmail.com>
2019-01-16 17:28:14 -05:00
Matt Layher
f62fd2bfc9
promql: use subtests in TestLexer
...
Signed-off-by: Matt Layher <mdlayher@gmail.com>
2019-01-16 16:39:32 -05:00
Matt Layher
43c9d9e91f
promql: apply golint suggestions ( #5066 )
...
Signed-off-by: Matt Layher <mdlayher@gmail.com>
2019-01-08 18:26:02 +00:00
beorn7
305f383af4
Adjust test_test.go to new Select return order
...
Signed-off-by: beorn7 <beorn@soundcloud.com>
2019-01-08 13:54:50 +01:00
beorn7
d6841c52e0
Merge branch 'release-2.6'
2019-01-08 12:46:18 +01:00
Ganesh Vernekar
341f04ca9c
Empty slice after last append in promql test LazyLoader
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2019-01-07 19:07:27 +05:30
Simon Pasquier
f678e27eb6
*: use latest release of staticcheck ( #5057 )
...
* *: use latest release of staticcheck
It also fixes a couple of things in the code flagged by the additional
checks.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Use official release of staticcheck
Also run 'go list' before staticcheck to avoid failures when downloading packages.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2019-01-04 14:47:38 +01:00
Tom Wilkie
6e08029b56
Move err to be the last return value from storage.Select. ( #5054 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2019-01-02 11:10:13 +00:00
Ganesh Vernekar
dbe55c1352
Subquery ( #4831 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-12-22 13:47:13 +00:00
Tom Wilkie
e1d9bf77f1
Export the error field in ErrStorage, so we can 'throw' it outside the package. ( #4954 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-12-04 16:49:21 +00:00
mknapphrt
f0e9196dca
Return warnings on a remote read fail ( #4832 )
...
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
2018-11-30 14:27:12 +00:00
Ben Kochie
c6399296dc
Fix spelling/typos ( #4921 )
...
* Fix spelling/typos
Fix spelling/typos reported by codespell/misspell.
* UK -> US spelling changes.
Signed-off-by: Ben Kochie <superq@gmail.com>
2018-11-27 17:44:29 +01:00
Ganesh Vernekar
cfb3769274
Lazily load samples for unit testing ( #4851 )
...
* Lazily load samples for unit testing
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* cleanup
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-11-22 14:21:38 +05:30
Ganesh Vernekar
ca93fd544b
/api/v1/labels endpoint for getting all label names ( #4835 )
...
* vendor: update tsdb
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* /api/v1/labels endpoint
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* regex matchers for API
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Add docs
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Matchers behaving as OR
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Removed the matchers
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* vendor: update tsdb using go mod
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* vendor update: tsdb
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Added LabelNames() to storage.Querier
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Test for api.labelNames
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Nits
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-11-19 15:51:14 +05:30
Goutham Veeramachaneni
1f053f897b
Merge pull request #4628 from bboreham/fix-storage-error
...
Make ErrStorage a concrete type not an interface
2018-11-14 10:39:16 +01:00
Brian Brazil
8edaa8ad4d
Fix goroutine leak in lexer/parser. ( #4858 )
...
When there was an error in the parser, the
lexer goroutine was left running.
Also make runtime panic test actually test things.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
2018-11-12 18:47:13 +00:00
Frederic Branczyk
bda9781ccd
Merge pull request #3839 from brancz/remove-old-alert-record
...
promql: Remove old and unused alerting/reconding syntax
2018-11-06 15:53:27 +01:00
Chris Marchbanks
ab3cdb9500
Allow promql benchmarks to query more samples ( #4770 )
...
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
2018-10-22 18:02:22 +01:00
Kangseok Thomas Lee
bec1a2f038
Reordering fields of String datetype ( #4751 )
...
Other types has timestamp as first field, but only String type has value as first field.
Signed-off-by: gangseok.lee <gangseok.lee@samsung.com>
2018-10-17 08:52:23 +01:00
Vandewilly
1098ed89d8
Drop 'else' condition when 'if' ends with a return ( #4743 )
...
This commit drops the else condition when the if block ends with a
return statement.
Signed-off-by: Vandewilly Silva <vandewilly.oli.silva@hpe.com>
2018-10-15 23:51:55 +01:00
Bryan Boreham
9a956872a3
Make ErrorStorage a concrete type not an interface
...
Since it is used in a type assertion, having it as an alias to the
error interface is the same as saying 'error', i.e. it succeeds for
all types of error. Change to a struct which is a concrete type and
the type assertion will only succeed if the type is identical.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2018-10-04 13:13:41 +00:00
Callum Styan
9bca041285
WIP: keep track of samples per query, set a max # of samples ( #4513 )
...
* keep track of samples per query, set a max # of samples that can be in
memory at once
Signed-off-by: Callum Styan <callumstyan@gmail.com>
2018-10-02 12:59:19 +01:00
Thomas Jackson
abf6fe0a98
Change max/min over_time to handle NaNs properly ( #4386 )
...
We only want to return a NaN if the NaN is the only value
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4385
2018-09-26 08:58:16 +01:00
Tom Wilkie
4c52400708
Limit concurrent remote reads. ( #4656 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-09-25 20:07:34 +01:00
Harsh Agarwal
18a9a390b5
Add duplicate-labelset check for range/instant vectors ( #4589 )
...
Signed-off-by: Harsh Agarwal <cs15btech11019@iith.ac.in>
2018-09-18 10:46:13 +01:00
Ganesh Vernekar
576ee4d309
Label name check for 'count_values' ( #4585 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-09-13 15:27:36 +05:30
Ganesh Vernekar
73db8b8cea
[bugfix] Parse negative value in PromQL ( #4564 )
...
* Parse negative value in PromQL
* Enforce space between values
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
2018-09-13 09:08:01 +01:00
Dan Cech
9f4cb06a37
use Welford/Knuth method to compute standard deviation and variance ( #4533 )
...
* use Welford/Knuth method to compute standard deviation and variance, avoids float precision issues
* use better method for calculating avg and avg_over_time
Signed-off-by: Dan Cech <dcech@grafana.com>
2018-08-26 10:28:47 +01:00
Julius Volz
8fbe1b5133
Handle a bunch of unchecked errors ( #4461 )
...
There are many more (mostly finalizers like Close/Stop/etc.), but most of
the others seemed like one couldn't do much about them anyway.
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-08-17 17:24:35 +02:00
Goutham Veeramachaneni
71855a22a4
Add tracing spans to promql ( #4436 )
...
* Add spans to promql
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
* Simplify timer and span tracking.
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
2018-08-16 13:11:34 +05:30
Frederic Branczyk
b0b3e3dd74
promql: Remove old and unused alerting/reconding syntax
...
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
2018-08-07 15:14:06 +02:00
Benjamin Raskin
9353696d77
Fix spelling and holt-winters check ( #4424 )
...
Signed-off-by: Benjamin Raskin <braskin@uber.com>
2018-07-27 18:17:43 +01:00
Thomas Jackson
56daa1f28a
Only add LookbackDelta to vector selectors ( #4399 )
...
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Related to #4226
2018-07-19 06:16:05 +01:00
Alin Sinpalean
372e7652b7
Reuse (copy) overlapping matrix samples between range evaluation steps ( #4315 )
...
* Reuse (copy) overlapping matrix samples between range evaluation steps.
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-07-18 11:14:02 +01:00
Tony Lee
bcdaf8e2d2
add unused pointslices to the pool ( #4363 )
...
Signed-off-by: Tony Lee <tl@hudson-trading.com>
2018-07-18 05:29:21 +01:00
Alin Sinpalean
e3b775b78b
Simplify BufferedSeriesIterator usage ( #4294 )
...
* Allow for BufferedSeriesIterator instances to be created without an underlying iterator, to simplify their usage.
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-07-18 05:10:28 +01:00
Julius Volz
219e477272
Fix some (valid) lint errors ( #4287 )
...
Signed-off-by: Julius Volz <julius.volz@gmail.com>
2018-07-18 05:07:33 +01:00
Thomas Jackson
92c6f0c92e
Add offset to selectParams ( #4226 )
...
* Add Start/End to SelectParams
* Make remote read use the new selectParams for start/end
This commit will continue sending the start/end time of the remote read
query as the overarching promql time and the specific range of data that
the query is intersted in receiving a response to is now part of the
ReadHints (upstream discussion in #4226 ).
* Remove unused vendored code
The genproto.sh script was updated, but the code wasn't regenerated.
This simply removes the vendored deps that are no longer part of the
codegen output.
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
2018-07-18 04:58:00 +01:00
Alin Sinpalean
96fb0b2155
Optimize PromQL aggregations ( #4248 )
...
* Compute hash of label subsets without creating a LabelSet first.
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-07-18 04:56:27 +01:00
Tom Wilkie
3228814456
Don't forget to register query_duration_seconds{slice="queue_time"} ( #4381 )
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-07-15 12:24:37 +01:00
Thomas Jackson
a6dace8829
Check for timeout in each iteration of matrixSelector ( #4300 )
...
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4288
2018-06-21 22:43:31 +01:00
Thomas Jackson
630f42fcf1
Timeout if populating iterators takes too long ( #4291 )
...
Right now promql won't time out a request if populating the iterators
takes a long time.
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Fixes #4289
2018-06-21 08:14:51 +01:00
Alin Sinpalean
91ce63a140
Log the line when failing a PromQL test. ( #4272 )
...
Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
2018-06-14 15:18:16 +01:00