RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Code Review: Avenues for future improvemnet noted.

This commit is contained in:
Matt T. Proud 2013-05-22 14:13:05 +02:00
parent 298a90c143
commit f994482d15
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
storage/metric/memory.go
View File

@ -52,6 +52,8 @@ func (s *stream) add(timestamp time.Time, value model.SampleValue) {
s.Lock()
defer s.Unlock()
// BUG(all): https://github.com/prometheus/prometheus/pull/265/files#r4336435.
s.values = append(s.values, model.SamplePair{
Timestamp: timestamp,
Value: value,
@ -62,6 +64,8 @@ func (s *stream) clone() model.Values {
s.RLock()
defer s.RUnlock()
// BUG(all): Examine COW technique.
clone := make(model.Values, len(s.values))
copy(clone, s.values)
@ -72,6 +76,7 @@ func (s *stream) getValueAtTime(t time.Time) model.Values {
s.RLock()
defer s.RUnlock()
// BUG(all): May be avenues for simplification.
l := len(s.values)
switch l {
case 0: