mirror of
https://github.com/prometheus/prometheus
synced 2024-12-23 23:13:11 +00:00
Add PR template
Signed-off-by: Richard Hartmann <richih@richih.org>
This commit is contained in:
parent
4a5aef0495
commit
f76dd36d17
16
.github/PULL_REQUEST_TEMPLATE.md
vendored
16
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -1,15 +1,17 @@
|
||||
<!--
|
||||
Don't forget!
|
||||
|
||||
|
||||
- Sign your commits and our DCO: https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits
|
||||
|
||||
- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.
|
||||
|
||||
|
||||
- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.
|
||||
|
||||
|
||||
- No tests are needed for internal implementation changes.
|
||||
|
||||
|
||||
- Performance improvements would need a benchmark test to prove it.
|
||||
|
||||
|
||||
- All exposed objects should have a comment.
|
||||
|
||||
|
||||
- All comments should start with a capital letter and end with a full stop.
|
||||
-->
|
||||
-->
|
||||
|
Loading…
Reference in New Issue
Block a user