mirror of
https://github.com/prometheus/prometheus
synced 2024-12-26 00:23:18 +00:00
discovery/kubernetes: improve test logic for waiting for discoverers (#9584)
When running tests in parallel, 10 milliseconds may not be enough for all discoverers to register, which will make test flaky. This commit changes the waiting logic to wait for number of discoverers to stop increasing during given time frame, which should be large enough for single discoverer to register in test environment. A following run passes with this commit: go test -failfast -race -count 100 -v ./discovery/kubernetes/ Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
This commit is contained in:
parent
c3beca72e2
commit
ea924746b3
@ -86,15 +86,18 @@ func (d k8sDiscoveryTest) Run(t *testing.T) {
|
||||
// Ensure that discovery has a discoverer set. This prevents a race
|
||||
// condition where the above go routine may or may not have set a
|
||||
// discoverer yet.
|
||||
for {
|
||||
lastDiscoverersCount := 0
|
||||
dis := d.discovery.(*Discovery)
|
||||
for {
|
||||
dis.RLock()
|
||||
l := len(dis.discoverers)
|
||||
dis.RUnlock()
|
||||
if l > 0 {
|
||||
if l > 0 && l == lastDiscoverersCount {
|
||||
break
|
||||
}
|
||||
time.Sleep(10 * time.Millisecond)
|
||||
time.Sleep(100 * time.Millisecond)
|
||||
|
||||
lastDiscoverersCount = l
|
||||
}
|
||||
|
||||
resChan := make(chan map[string]*targetgroup.Group)
|
||||
|
Loading…
Reference in New Issue
Block a user