Merge pull request #2690 from prometheus/beorn7/storage

storage: Correctly increase prometheus_local_storage_open_head_chunks
This commit is contained in:
Fabian Reinartz 2017-05-09 07:28:13 +02:00 committed by GitHub
commit e9c25131fe

View File

@ -927,6 +927,7 @@ func (s *MemorySeriesStorage) Append(sample *model.Sample) error {
s.discardedSamples.WithLabelValues(outOfOrderTimestamp).Inc() s.discardedSamples.WithLabelValues(outOfOrderTimestamp).Inc()
return ErrOutOfOrderSample // Caused by the caller. return ErrOutOfOrderSample // Caused by the caller.
} }
headChunkWasClosed := series.headChunkClosed
completedChunksCount, err := series.add(model.SamplePair{ completedChunksCount, err := series.add(model.SamplePair{
Value: sample.Value, Value: sample.Value,
Timestamp: sample.Timestamp, Timestamp: sample.Timestamp,
@ -935,6 +936,11 @@ func (s *MemorySeriesStorage) Append(sample *model.Sample) error {
s.quarantineSeries(fp, sample.Metric, err) s.quarantineSeries(fp, sample.Metric, err)
return err return err
} }
if headChunkWasClosed {
// Appending to a series with a closed head chunk creates an
// additional open head chunk.
s.headChunks.Inc()
}
s.ingestedSamples.Inc() s.ingestedSamples.Inc()
s.incNumChunksToPersist(completedChunksCount) s.incNumChunksToPersist(completedChunksCount)