From e9129abeff4fd3686b2d777e87ecb5ca8ed87c65 Mon Sep 17 00:00:00 2001 From: Callum Styan Date: Mon, 10 Jun 2019 12:43:08 -0700 Subject: [PATCH] Remove max_retries from queue_config since it's not used in remote write anymore. Signed-off-by: Callum Styan --- config/config.go | 6 +----- docs/configuration/configuration.md | 2 -- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/config/config.go b/config/config.go index f4d8d470d..1ddcfdd8a 100644 --- a/config/config.go +++ b/config/config.go @@ -116,8 +116,7 @@ var ( Capacity: 10, BatchSendDeadline: model.Duration(5 * time.Second), - // Max number of times to retry a batch on recoverable errors. - MaxRetries: 3, + // Backoff times for retrying a batch of samples on recoverable errors. MinBackoff: model.Duration(30 * time.Millisecond), MaxBackoff: model.Duration(100 * time.Millisecond), } @@ -594,9 +593,6 @@ type QueueConfig struct { // Maximum time sample will wait in buffer. BatchSendDeadline model.Duration `yaml:"batch_send_deadline,omitempty"` - // Max number of times to retry a batch on recoverable errors. - MaxRetries int `yaml:"max_retries,omitempty"` - // On recoverable errors, backoff exponentially. MinBackoff model.Duration `yaml:"min_backoff,omitempty"` MaxBackoff model.Duration `yaml:"max_backoff,omitempty"` diff --git a/docs/configuration/configuration.md b/docs/configuration/configuration.md index e631cd674..1da9843a3 100644 --- a/docs/configuration/configuration.md +++ b/docs/configuration/configuration.md @@ -1298,8 +1298,6 @@ queue_config: [ max_samples_per_send: | default = 100] # Maximum time a sample will wait in buffer. [ batch_send_deadline: | default = 5s ] - # Maximum number of times to retry a batch on recoverable errors. - [ max_retries: | default = 3 ] # Initial retry delay. Gets doubled for every retry. [ min_backoff: | default = 30ms ] # Maximum retry delay.