web: restore old path prefix behavior

Signed-off-by: Fabian Reinartz <freinartz@google.com>
This commit is contained in:
Fabian Reinartz 2018-06-12 08:07:09 -04:00 committed by Brian Brazil
parent 91ce63a140
commit e7cfc7dae5
2 changed files with 1 additions and 43 deletions

View File

@ -757,13 +757,7 @@ func tmplFuncs(consolesPath string, opts *Options) template_text.FuncMap {
return time.Since(t) / time.Millisecond * time.Millisecond
},
"consolesPath": func() string { return consolesPath },
"pathPrefix": func() string {
if opts.RoutePrefix == "/" {
return ""
} else {
return opts.RoutePrefix
}
},
"pathPrefix": func() string { return opts.ExternalURL.Path },
"buildVersion": func() string { return opts.Version.Revision },
"stripLabels": func(lset map[string]string, labels ...string) map[string]string {
for _, ln := range labels {

View File

@ -271,42 +271,6 @@ func TestRoutePrefix(t *testing.T) {
testutil.Ok(t, err)
testutil.Equals(t, http.StatusOK, resp.StatusCode)
}
func TestPathPrefix(t *testing.T) {
tests := []struct {
routePrefix string
pathPrefix string
}{
{
routePrefix: "/",
// If we have pathPrefix as "/", URL in UI gets "//"" as prefix,
// hence doesn't remain relative path anymore.
pathPrefix: "",
},
{
routePrefix: "/prometheus",
pathPrefix: "/prometheus",
},
{
routePrefix: "/p1/p2/p3/p4",
pathPrefix: "/p1/p2/p3/p4",
},
}
for _, test := range tests {
opts := &Options{
RoutePrefix: test.routePrefix,
}
pathPrefix := tmplFuncs("", opts)["pathPrefix"].(func() string)
pp := pathPrefix()
testutil.Equals(t, test.pathPrefix, pp)
}
}
func TestDebugHandler(t *testing.T) {
for _, tc := range []struct {
prefix, url string