From e10bbf0a84d59a9f20144ed578c9afa7079dbacd Mon Sep 17 00:00:00 2001 From: Ben Ye Date: Sat, 30 Nov 2024 22:26:09 -0800 Subject: [PATCH] hot reload always_scrape_classic_histograms and convert_classic_histograms_to_nhcb configs properly Signed-off-by: Ben Ye --- scrape/scrape.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scrape/scrape.go b/scrape/scrape.go index eeab208d65..86405e0dc9 100644 --- a/scrape/scrape.go +++ b/scrape/scrape.go @@ -330,6 +330,8 @@ func (sp *scrapePool) restartLoops(reuseCache bool) { trackTimestampsStaleness = sp.config.TrackTimestampsStaleness mrc = sp.config.MetricRelabelConfigs fallbackScrapeProtocol = sp.config.ScrapeFallbackProtocol.HeaderMediaType() + alwaysScrapeClassicHist = sp.config.AlwaysScrapeClassicHistograms + convertClassicHistToNHCB = sp.config.ConvertClassicHistogramsToNHCB ) validationScheme := model.UTF8Validation @@ -377,6 +379,8 @@ func (sp *scrapePool) restartLoops(reuseCache bool) { timeout: timeout, validationScheme: validationScheme, fallbackScrapeProtocol: fallbackScrapeProtocol, + alwaysScrapeClassicHist: alwaysScrapeClassicHist, + convertClassicHistToNHCB: convertClassicHistToNHCB, }) ) if err != nil {