diff --git a/rules/manager.go b/rules/manager.go index 92675e71d..acc637e71 100644 --- a/rules/manager.go +++ b/rules/manager.go @@ -190,7 +190,7 @@ func (m *Manager) Stop() { // Update the rule manager's state as the config requires. If // loading the new rules failed the old rule set is restored. -// This method will no-op in case the manager is already stopped +// This method will no-op in case the manager is already stopped. func (m *Manager) Update(interval time.Duration, files []string, externalLabels labels.Labels, externalURL string, groupEvalIterationFunc GroupEvalIterationFunc) error { m.mtx.Lock() defer m.mtx.Unlock() diff --git a/rules/manager_test.go b/rules/manager_test.go index ec967df24..51239e6c9 100644 --- a/rules/manager_test.go +++ b/rules/manager_test.go @@ -2111,7 +2111,7 @@ func TestUpdateWhenStopped(t *testing.T) { require.NotEmpty(t, ruleManager.groups) ruleManager.Stop() - // Updates following a stop are no-op + // Updates following a stop are no-op. err = ruleManager.Update(10*time.Second, []string{}, labels.EmptyLabels(), "", nil) require.NoError(t, err) }