From 21afc0beb41458dc423a3319698c5a07ba12147b Mon Sep 17 00:00:00 2001 From: Neeraj Gartia Date: Tue, 28 Jan 2025 02:05:30 +0530 Subject: [PATCH 1/2] adds tests for sum_over_time and avg_over_time Signed-off-by: Neeraj Gartia --- promql/promqltest/testdata/functions.test | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/promql/promqltest/testdata/functions.test b/promql/promqltest/testdata/functions.test index fadd29c53c..23d0101566 100644 --- a/promql/promqltest/testdata/functions.test +++ b/promql/promqltest/testdata/functions.test @@ -810,6 +810,8 @@ load 10s metric9 -9.988465674311579e+307 -9.988465674311579e+307 -9.988465674311579e+307 metric10 -9.988465674311579e+307 9.988465674311579e+307 metric11 1 2 3 NaN NaN + metric12 1 2 3 {{schema:0 sum:1 count:1}} {{schema:0 sum:3 count:3}} + metric13 {{schema:0 sum:1 count:1}}x5 eval instant at 55s avg_over_time(metric[1m]) {} 3 @@ -916,6 +918,23 @@ eval instant at 1m avg_over_time(metric11[1m]) eval instant at 1m sum_over_time(metric11[1m])/count_over_time(metric11[1m]) {} NaN +# Tests for samples with mix of floats and histograms. +eval_warn instant at 1m sum_over_time(metric12[1m]) + # no result. + +eval_warn instant at 1m avg_over_time(metric12[1m]) + # no result. + +# Tests for samples with only histograms. +eval instant at 1m sum_over_time(metric13[1m]) + {} {{schema:0 sum:5 count:5}} + +eval instant at 1m avg_over_time(metric13[1m]) + {} {{schema:0 sum:1 count:1}} + +eval instant at 1m sum_over_time(metric13[1m])/count_over_time(metric13[1m]) + {} {{schema:0 sum:1 count:1}} + # Test if very big intermediate values cause loss of detail. clear load 10s From b9fcc81695eae37169afb90c05865e48a8feb6f4 Mon Sep 17 00:00:00 2001 From: Neeraj Gartia Date: Tue, 28 Jan 2025 02:10:36 +0530 Subject: [PATCH 2/2] adds tests for timestamp() Signed-off-by: Neeraj Gartia --- promql/promqltest/testdata/functions.test | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/promql/promqltest/testdata/functions.test b/promql/promqltest/testdata/functions.test index 23d0101566..9bcb7e6945 100644 --- a/promql/promqltest/testdata/functions.test +++ b/promql/promqltest/testdata/functions.test @@ -419,7 +419,7 @@ clear # Tests for vector, time and timestamp. load 10s - metric 1 1 + metric 1 1 {{schema:0 sum:1 count:1}} eval instant at 0s timestamp(metric) {} 0 @@ -436,6 +436,9 @@ eval instant at 10s timestamp(metric) eval instant at 10s timestamp(((metric))) {} 10 +eval instant at 20s timestamp(metric) + {} 20 + # Tests for label_join. load 5m testmetric{src="a",src1="b",src2="c",dst="original-destination-value"} 0