From d15869af32f918b9a958c3a73144f4834c935a75 Mon Sep 17 00:00:00 2001 From: Alan Protasio Date: Wed, 24 Apr 2024 07:41:33 -0700 Subject: [PATCH] Avoid creating new slices for labels values on postings for matchers (#13958) * Avoid creating new slices for labels values on postings for matchers Signed-off-by: alanprot * refactor Signed-off-by: alanprot --------- Signed-off-by: alanprot --- tsdb/querier.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tsdb/querier.go b/tsdb/querier.go index 8ebedfe52..a6763e996 100644 --- a/tsdb/querier.go +++ b/tsdb/querier.go @@ -331,7 +331,7 @@ func postingsForMatcher(ctx context.Context, ix IndexReader, m *labels.Matcher) return nil, err } - var res []string + res := vals[:0] for _, val := range vals { if m.Matches(val) { res = append(res, val) @@ -368,7 +368,7 @@ func inversePostingsForMatcher(ctx context.Context, ix IndexReader, m *labels.Ma return nil, err } - var res []string + res := vals[:0] // If the inverse match is ="", we just want all the values. if m.Type == labels.MatchEqual && m.Value == "" { res = vals