RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

labels: use Equal instead of DeepEqual 

This will work better with a different data structure.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2023-03-24 17:58:25 +00:00
parent 4d6bb2e0e4
commit cc5dc6a61b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
model/labels/labels_test.go
View File

@ -114,7 +114,7 @@ func TestLabels_MatchLabels(t *testing.T) {
for i, test := range tests { for i, test := range tests {
got := labels.MatchLabels(test.on, test.providedNames...) got := labels.MatchLabels(test.on, test.providedNames...)
require.Equal(t, test.expected, got, "unexpected labelset for test case %d", i) require.True(t, Equal(test.expected, got), "unexpected labelset for test case %d", i)
} }
} }
@ -207,7 +207,7 @@ func TestLabels_WithoutEmpty(t *testing.T) {
}, },
} { } {
t.Run("", func(t *testing.T) { t.Run("", func(t *testing.T) {
require.Equal(t, test.expected, test.input.WithoutEmpty()) require.True(t, Equal(test.expected, test.input.WithoutEmpty()))
}) })
} }
} }
@ -647,7 +647,7 @@ func TestBuilder(t *testing.T) {
b.Keep(tcase.keep...) b.Keep(tcase.keep...)
} }
b.Del(tcase.del...) b.Del(tcase.del...)
require.Equal(t, tcase.want, b.Labels()) require.True(t, Equal(tcase.want, b.Labels()))
// Check what happens when we call Range and mutate the builder. // Check what happens when we call Range and mutate the builder.
b.Range(func(l Label) { b.Range(func(l Label) {
@ -694,14 +694,14 @@ func TestScratchBuilder(t *testing.T) {
}, },
} { } {
t.Run(fmt.Sprint(i), func(t *testing.T) { t.Run(fmt.Sprint(i), func(t *testing.T) {
b := ScratchBuilder{} b := NewScratchBuilder(len(tcase.add))
for _, lbl := range tcase.add { for _, lbl := range tcase.add {
b.Add(lbl.Name, lbl.Value) b.Add(lbl.Name, lbl.Value)
} }
b.Sort() b.Sort()
require.Equal(t, tcase.want, b.Labels()) require.True(t, Equal(tcase.want, b.Labels()))
b.Assign(tcase.want) b.Assign(tcase.want)
require.Equal(t, tcase.want, b.Labels()) require.True(t, Equal(tcase.want, b.Labels()))
}) })
} }
} }