RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Show the warnings during label query (#5924) 

This patch loops through the warnings while querying the label and spits the
output to stderr

Fixes #5885

Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
This commit is contained in:
Sayan Chowdhury 2019-08-24 23:12:21 +05:30 committed by Julius Volz
parent ac3cedb108
commit cb66e325d8
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/promtool/main.go
View File

@ -501,10 +501,13 @@ func QueryLabels(url *url.URL, name string, p printer) int {
// Run query against client.
api := v1.NewAPI(c)
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
// TODO: Show warnings (second return value) somehow? See https://github.com/prometheus/prometheus/issues/5885
val, _, err := api.LabelValues(ctx, name)
val, warn, err := api.LabelValues(ctx, name)
cancel()
for _, v := range warn {
fmt.Fprintln(os.Stderr, "query warning:", v)
}
if err != nil {
fmt.Fprintln(os.Stderr, "query error:", err)
return 1