RepoMirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus synced 2024-12-27 00:53:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

scrape: remove unused argument in newScrapeLoop (#11283)

Browse Source 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This commit is contained in:
Bogdan Drutu 2022-09-07 14:59:57 -07:00 committed by GitHub
parent 96d5a32659
commit c8cfe5c25d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scrape/scrape.go
View File

@ -321,7 +321,6 @@ func newScrapePool(cfg *config.ScrapeConfig, app storage.Appendable, jitterSeed
options.ExtraMetrics,
options.EnableMetadataStorage,
opts.target,
cache,
options.PassMetadataInContext,
)
}
@ -1146,7 +1145,6 @@ func newScrapeLoop(ctx context.Context,
reportExtraMetrics bool,
appendMetadataToWAL bool,
target *Target,
metricMetadataStore MetricMetadataStore,
passMetadataInContext bool,
) *scrapeLoop {
if l == nil {

32
scrape/scrape_test.go
View File

@ -627,7 +627,6 @@ func TestScrapeLoopStopBeforeRun(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -700,7 +699,6 @@ func TestScrapeLoopStop(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -776,7 +774,6 @@ func TestScrapeLoopRun(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -832,7 +829,6 @@ func TestScrapeLoopRun(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -892,7 +888,6 @@ func TestScrapeLoopForcedErr(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -951,7 +946,6 @@ func TestScrapeLoopMetadata(t *testing.T) {
false,
false,
nil,
nil,
false,
)
defer cancel()
@ -1009,7 +1003,6 @@ func simpleTestScrapeLoop(t testing.TB) (context.Context, *scrapeLoop) {
false,
false,
nil,
nil,
false,
)
t.Cleanup(func() { cancel() })
@ -1103,7 +1096,6 @@ func TestScrapeLoopRunCreatesStaleMarkersOnFailedScrape(t *testing.T) {
false,
false,
nil,
nil,
false,
)
// Succeed once, several failures, then stop.
@ -1166,7 +1158,6 @@ func TestScrapeLoopRunCreatesStaleMarkersOnParseFailure(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1233,7 +1224,6 @@ func TestScrapeLoopCache(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1316,7 +1306,6 @@ func TestScrapeLoopCacheMemoryExhaustionProtection(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1431,7 +1420,6 @@ func TestScrapeLoopAppend(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1520,7 +1508,7 @@ func TestScrapeLoopAppendForConflictingPrefixedLabels(t *testing.T) {
return mutateSampleLabels(l, &Target{labels: labels.FromStrings(tc.targetLabels...)}, false, nil)
},
nil,
func(ctx context.Context) storage.Appender { return app }, nil, 0, true, 0, nil, 0, 0, false, false, nil, nil, false,
func(ctx context.Context) storage.Appender { return app }, nil, 0, true, 0, nil, 0, 0, false, false, nil, false,
)
slApp := sl.appender(context.Background())
_, _, _, err := sl.append(slApp, []byte(tc.exposedLabels), "", time.Date(2000, 1, 1, 1, 0, 0, 0, time.UTC))
@ -1558,7 +1546,6 @@ func TestScrapeLoopAppendCacheEntryButErrNotFound(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1618,7 +1605,6 @@ func TestScrapeLoopAppendSampleLimit(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1696,7 +1682,6 @@ func TestScrapeLoop_ChangingMetricString(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1745,7 +1730,6 @@ func TestScrapeLoopAppendStaleness(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1797,7 +1781,6 @@ func TestScrapeLoopAppendNoStalenessIfTimestamp(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -1909,7 +1892,6 @@ metric_total{n="2"} 2 # {t="2"} 2.0 20000
false,
false,
nil,
nil,
false,
)
@ -1975,7 +1957,6 @@ func TestScrapeLoopAppendExemplarSeries(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2028,7 +2009,6 @@ func TestScrapeLoopRunReportsTargetDownOnScrapeError(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2065,7 +2045,6 @@ func TestScrapeLoopRunReportsTargetDownOnInvalidUTF8(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2115,7 +2094,6 @@ func TestScrapeLoopAppendGracefullyIfAmendOrOutOfOrderOrOutOfBounds(t *testing.T
false,
false,
nil,
nil,
false,
)
@ -2161,7 +2139,6 @@ func TestScrapeLoopOutOfBoundsTimeError(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2419,7 +2396,6 @@ func TestScrapeLoop_RespectTimestamps(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2461,7 +2437,6 @@ func TestScrapeLoop_DiscardTimestamps(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -2502,7 +2477,6 @@ func TestScrapeLoopDiscardDuplicateLabels(t *testing.T) {
false,
false,
nil,
nil,
false,
)
defer cancel()
@ -2561,7 +2535,6 @@ func TestScrapeLoopDiscardUnnamedMetrics(t *testing.T) {
false,
false,
nil,
nil,
false,
)
defer cancel()
@ -2838,7 +2811,6 @@ func TestScrapeAddFast(t *testing.T) {
false,
false,
nil,
nil,
false,
)
defer cancel()
@ -2930,7 +2902,6 @@ func TestScrapeReportSingleAppender(t *testing.T) {
false,
false,
nil,
nil,
false,
)
@ -3133,7 +3104,6 @@ func TestScrapeLoopLabelLimit(t *testing.T) {
false,
false,
nil,
nil,
false,
)