From c1f9917e90846e6162e53c8dff801f92694dd198 Mon Sep 17 00:00:00 2001 From: Chris Marchbanks Date: Thu, 30 Apr 2020 16:54:02 -0600 Subject: [PATCH] Add test for unregistering queue manager metrics Signed-off-by: Chris Marchbanks --- storage/remote/queue_manager_test.go | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/storage/remote/queue_manager_test.go b/storage/remote/queue_manager_test.go index 58e959a90..323ee7e5e 100644 --- a/storage/remote/queue_manager_test.go +++ b/storage/remote/queue_manager_test.go @@ -22,6 +22,7 @@ import ( "reflect" "sort" "strconv" + "strings" "sync" "sync/atomic" "testing" @@ -31,6 +32,7 @@ import ( "github.com/gogo/protobuf/proto" "github.com/golang/snappy" + "github.com/prometheus/client_golang/prometheus" client_testutil "github.com/prometheus/client_golang/prometheus/testutil" "github.com/prometheus/common/model" "github.com/prometheus/prometheus/config" @@ -685,3 +687,19 @@ func TestCalculateDesiredShards(t *testing.T) { } testutil.Assert(t, pendingSamples == 0, "Remote write never caught up, there are still %d pending samples.", pendingSamples) } + +func TestQueueManagerMetrics(t *testing.T) { + reg := prometheus.NewPedanticRegistry() + metrics := newQueueManagerMetrics(reg, "name", "http://localhost:1234") + + // Make sure metrics pass linting. + problems, err := client_testutil.GatherAndLint(reg) + testutil.Ok(t, err) + testutil.Equals(t, 0, len(problems), "Metric linting problems detected: %v", problems) + + // Make sure all metrics were unregistered. A failure here means you need + // unregister a metric in `queueManagerMetrics.unregister()`. + metrics.unregister() + err = client_testutil.GatherAndCompare(reg, strings.NewReader("")) + testutil.Ok(t, err) +}