From 835eb8c653fb642473b41c2c0296f3c0a944a812 Mon Sep 17 00:00:00 2001 From: Tom Wilkie Date: Fri, 7 Jul 2017 15:37:16 +0100 Subject: [PATCH] Add _test.go suffix to promql/{bench.go, test.go} to prevent importing the testing package in a normal binary. --- promql/{bench.go => bench_test.go} | 0 promql/test.go | 26 ------------------- promql/test_test.go | 40 ++++++++++++++++++++++++++++++ 3 files changed, 40 insertions(+), 26 deletions(-) rename promql/{bench.go => bench_test.go} (100%) create mode 100644 promql/test_test.go diff --git a/promql/bench.go b/promql/bench_test.go similarity index 100% rename from promql/bench.go rename to promql/bench_test.go diff --git a/promql/test.go b/promql/test.go index 8b10d450f..e65982713 100644 --- a/promql/test.go +++ b/promql/test.go @@ -419,32 +419,6 @@ func (cmd clearCmd) String() string { return "clear" } -// RunAsBenchmark runs the test in benchmark mode. -// This will not count any loads or non eval functions. -func (t *Test) RunAsBenchmark(b *Benchmark) error { - for _, cmd := range t.cmds { - - switch cmd.(type) { - // Only time the "eval" command. - case *evalCmd: - err := t.exec(cmd) - if err != nil { - return err - } - default: - if b.iterCount == 0 { - b.b.StopTimer() - err := t.exec(cmd) - if err != nil { - return err - } - b.b.StartTimer() - } - } - } - return nil -} - // Run executes the command sequence of the test. Until the maximum error number // is reached, evaluation errors do not terminate execution. func (t *Test) Run() error { diff --git a/promql/test_test.go b/promql/test_test.go new file mode 100644 index 000000000..5de250749 --- /dev/null +++ b/promql/test_test.go @@ -0,0 +1,40 @@ +// Copyright 2015 The Prometheus Authors +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, softwar +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package promql + +// RunAsBenchmark runs the test in benchmark mode. +// This will not count any loads or non eval functions. +func (t *Test) RunAsBenchmark(b *Benchmark) error { + for _, cmd := range t.cmds { + + switch cmd.(type) { + // Only time the "eval" command. + case *evalCmd: + err := t.exec(cmd) + if err != nil { + return err + } + default: + if b.iterCount == 0 { + b.b.StopTimer() + err := t.exec(cmd) + if err != nil { + return err + } + b.b.StartTimer() + } + } + } + return nil +}