From bb8363dbb30fc3864de8e837db11713022713958 Mon Sep 17 00:00:00 2001
From: Filip Petkovski <filip.petkovsky@gmail.com>
Date: Wed, 13 Dec 2023 08:30:02 +0100
Subject: [PATCH] Add comment on SampleRingIterator

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
---
 promql/engine.go  |  7 +------
 storage/buffer.go | 10 ++--------
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/promql/engine.go b/promql/engine.go
index 8b49879217..16b8ee5002 100644
--- a/promql/engine.go
+++ b/promql/engine.go
@@ -2114,12 +2114,7 @@ loop:
 				if floats == nil {
 					floats = getFPointSlice(16)
 				}
-				if n := len(floats); n < cap(floats) {
-					floats = floats[:n+1]
-					floats[n].T, floats[n].F = t, f
-				} else {
-					floats = append(floats, FPoint{T: t, F: f})
-				}
+				floats = append(floats, FPoint{T: t, F: f})
 			}
 		}
 	}
diff --git a/storage/buffer.go b/storage/buffer.go
index 75a935f9db..234771a770 100644
--- a/storage/buffer.go
+++ b/storage/buffer.go
@@ -310,6 +310,8 @@ func (r *sampleRing) iterator() *SampleRingIterator {
 	return &r.it
 }
 
+// SampleRingIterator is returned by BufferedSeriesIterator.Buffer() and can be
+// used to iterate samples buffered in the lookback window.
 type SampleRingIterator struct {
 	r  *sampleRing
 	i  int
@@ -358,14 +360,6 @@ func (it *SampleRingIterator) Next() chunkenc.ValueType {
 	}
 }
 
-func (it *SampleRingIterator) Seek(int64) chunkenc.ValueType {
-	return chunkenc.ValNone
-}
-
-func (it *SampleRingIterator) Err() error {
-	return nil
-}
-
 func (it *SampleRingIterator) At() (int64, float64) {
 	return it.t, it.f
 }