Review feedback.

Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
This commit is contained in:
Tom Wilkie 2018-05-29 11:35:43 +01:00
parent 3353bbd018
commit b58199bf12
2 changed files with 2 additions and 2 deletions

View File

@ -74,7 +74,7 @@ func TestStoreHTTPErrorHandling(t *testing.T) {
t.Fatal(err)
}
err = c.Store(context.TODO(), &prompb.WriteRequest{})
err = c.Store(context.Background(), &prompb.WriteRequest{})
if !reflect.DeepEqual(err, test.err) {
t.Errorf("%d. Unexpected error; want %v, got %v", i, test.err, err)
}

View File

@ -420,7 +420,7 @@ func (s *shards) stop(deadline time.Duration) {
level.Error(s.qm.logger).Log("msg", "Failed to flush all samples on shutdown")
}
// Force a unclean shutdown.
// Force an unclean shutdown.
s.cancel()
<-s.done
return