From ab60bc3929de17e18965f85c735f9d0ba48b4e4a Mon Sep 17 00:00:00 2001 From: Tristan Colgate Date: Fri, 4 Nov 2016 11:06:07 +0000 Subject: [PATCH] Fix export of grouping modifier --- promql/printer.go | 4 +--- promql/printer_test.go | 6 +++++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/promql/printer.go b/promql/printer.go index 79141e06e..40ca02e65 100644 --- a/promql/printer.go +++ b/promql/printer.go @@ -176,9 +176,7 @@ func (node *BinaryExpr) String() string { } else { matching += "RIGHT" } - if len(vm.Include) > 0 { - matching += fmt.Sprintf("(%s)", vm.Include) - } + matching += fmt.Sprintf("(%s)", vm.Include) } } return fmt.Sprintf("%s %s%s%s %s", node.LHS, node.Op, returnBool, matching, node.RHS) diff --git a/promql/printer_test.go b/promql/printer_test.go index 1715b54fc..2419a2b39 100644 --- a/promql/printer_test.go +++ b/promql/printer_test.go @@ -94,7 +94,11 @@ func TestExprString(t *testing.T) { in: `a - ON(b) GROUP_LEFT(x, y) c`, }, { - in: `a - ON(b) GROUP_LEFT c`, + in: `a - ON(b) GROUP_LEFT c`, + out: `a - ON(b) GROUP_LEFT() c`, + }, + { + in: `a - ON(b) GROUP_LEFT() (c)`, }, { in: `a - IGNORING(b) c`,