RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PromQL: Fix parser benchmark (#6495) 

The parser benchmarks called the `ParseMetric` function instead of the `ParseExpr` function, which resulted in parsing failing every time.

This means only the case of PromQL parser failure was benchmarked.

Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>
This commit is contained in:
Tobias Guggenmos 2019-12-20 12:30:41 +01:00 committed by Brian Brazil
parent 1e0cd28bf6
commit a48acbcb23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
promql/bench_test.go
View File

@ -250,7 +250,7 @@ func BenchmarkParser(b *testing.B) {
b.Run(c, func(b *testing.B) { b.Run(c, func(b *testing.B) {
b.ReportAllocs() b.ReportAllocs()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
ParseMetric(c) ParseExpr(c)
} }
}) })
} }
@ -259,7 +259,7 @@ func BenchmarkParser(b *testing.B) {
b.Run(name, func(b *testing.B) { b.Run(name, func(b *testing.B) {
b.ReportAllocs() b.ReportAllocs()
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
ParseMetric(c) ParseExpr(c)
} }
}) })
} }