From 8ee7947b1ef5ce984c9fd2672ca18e53fe086f22 Mon Sep 17 00:00:00 2001 From: Julius Volz Date: Fri, 14 Jun 2013 13:03:19 +0200 Subject: [PATCH] Ensure metric name is dropped correctly from alert labels in UI. --- rules/alerting.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rules/alerting.go b/rules/alerting.go index dd269fc5e..e0f1e4157 100644 --- a/rules/alerting.go +++ b/rules/alerting.go @@ -115,7 +115,8 @@ func (rule *AlertingRule) Eval(timestamp time.Time, storage *metric.TieredStorag rule.mutex.Lock() defer rule.mutex.Unlock() - // Create pending alerts for any new vector elements in the alert expression. + // Create pending alerts for any new vector elements in the alert expression + // or update the expression value for existing elements. resultFingerprints := utility.Set{} for _, sample := range exprResult { fp := *model.NewFingerprintFromMetric(sample.Metric) @@ -129,7 +130,7 @@ func (rule *AlertingRule) Eval(timestamp time.Time, storage *metric.TieredStorag } rule.activeAlerts[fp] = &Alert{ Name: rule.name, - Labels: sample.Metric.ToLabelSet(), + Labels: labels, State: PENDING, ActiveSince: timestamp, Value: sample.Value,