From 8472596fd0673b972ca8d1e957ff997fe26db401 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Gouteroux?= <francois.gouteroux@gmail.com>
Date: Wed, 5 Apr 2023 11:24:49 +0200
Subject: [PATCH] fix: apply suggested changes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
---
 cmd/promtool/main.go          | 18 ++++++++++++------
 docs/command-line/promtool.md |  6 +++---
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/cmd/promtool/main.go b/cmd/promtool/main.go
index abac38d5f..b3d743e44 100644
--- a/cmd/promtool/main.go
+++ b/cmd/promtool/main.go
@@ -132,7 +132,7 @@ func main() {
 	ruleFiles := checkRulesCmd.Arg(
 		"rule-files",
 		"The rule files to check, default is read from standard input (STDIN).",
-	).Default("-").Strings()
+	).ExistingFiles()
 	checkRulesLint := checkRulesCmd.Flag(
 		"lint",
 		"Linting checks to apply. Available options are: "+strings.Join(lintOptions, ", ")+". Use --lint=none to disable linting",
@@ -690,6 +690,11 @@ func CheckRules(ls lintConfig, files ...string) int {
 	failed := false
 	hasErrors := false
 
+	// add empty string to avoid matching filename
+	if len(files) == 0 {
+		files = append(files, "")
+	}
+
 	for _, f := range files {
 		if n, errs := checkRules(f, ls); errs != nil {
 			fmt.Fprintln(os.Stderr, "  FAILED:")
@@ -717,15 +722,16 @@ func CheckRules(ls lintConfig, files ...string) int {
 func checkRules(filename string, lintSettings lintConfig) (int, []error) {
 	var rgs *rulefmt.RuleGroups
 	var errs []error
-	if filename == "-" || filename == "" {
-		var buf bytes.Buffer
-		tee := io.TeeReader(os.Stdin, &buf)
-		if _, err := buf.ReadFrom(tee); err != nil {
+
+	// if filename is an empty string it is a stdin
+	if filename == "" {
+		data, err := io.ReadAll(os.Stdin)
+		if err != nil {
 			errs = append(errs, err)
 			return failureExitCode, errs
 		}
 		fmt.Println("Checking stdin")
-		rgs, errs = rulefmt.Parse(buf.Bytes())
+		rgs, errs = rulefmt.Parse(data)
 	} else {
 		fmt.Println("Checking", filename)
 		rgs, errs = rulefmt.ParseFile(filename)
diff --git a/docs/command-line/promtool.md b/docs/command-line/promtool.md
index 6b67408c9..59c46dd79 100644
--- a/docs/command-line/promtool.md
+++ b/docs/command-line/promtool.md
@@ -179,9 +179,9 @@ Check if the rule files are valid or not.
 
 ###### Arguments
 
-| Argument | Description | Default |
-| --- | --- | --- |
-| rule-files | The rule files to check, default is read from standard input (STDIN). | `-` |
+| Argument | Description |
+| --- | --- |
+| rule-files | The rule files to check, default is read from standard input (STDIN). |