comment to rethink the map reference for the notifier discovery
This commit is contained in:
parent
2e058b1c6f
commit
8369826808
|
@ -296,6 +296,7 @@ func main() {
|
|||
c := make(map[string]sd_config.ServiceDiscoveryConfig)
|
||||
for _, v := range cfg.AlertingConfig.AlertmanagerConfigs {
|
||||
// AlertmanagerConfigs doesn't hold an unique identifier so we use the config pointer as the identifier.
|
||||
// TODO Krasi - Maybe use the slice index as the reference.
|
||||
c[fmt.Sprintf("%p", v)] = v.ServiceDiscoveryConfig
|
||||
}
|
||||
return discoveryManagerNotify.ApplyConfig(c)
|
||||
|
|
|
@ -257,6 +257,7 @@ func (n *Notifier) ApplyConfig(conf *config.Config) error {
|
|||
ams.metrics = n.metrics
|
||||
|
||||
// The config pointer is used for the map lookup identifier.
|
||||
// TODO Krasi - Maybe use the slice index as the reference.
|
||||
amSets[fmt.Sprintf("%p", cfg)] = ams
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue