RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

comment to rethink the map reference for the notifier discovery

This commit is contained in:
Krasi Georgiev 2018-01-16 09:47:53 +00:00
parent 2e058b1c6f
commit 8369826808
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/prometheus/main.go
View File

@ -296,6 +296,7 @@ func main() {
c := make(map[string]sd_config.ServiceDiscoveryConfig) c := make(map[string]sd_config.ServiceDiscoveryConfig)
for _, v := range cfg.AlertingConfig.AlertmanagerConfigs { for _, v := range cfg.AlertingConfig.AlertmanagerConfigs {
// AlertmanagerConfigs doesn't hold an unique identifier so we use the config pointer as the identifier. // AlertmanagerConfigs doesn't hold an unique identifier so we use the config pointer as the identifier.
// TODO Krasi - Maybe use the slice index as the reference.
c[fmt.Sprintf("%p", v)] = v.ServiceDiscoveryConfig c[fmt.Sprintf("%p", v)] = v.ServiceDiscoveryConfig
} }
return discoveryManagerNotify.ApplyConfig(c) return discoveryManagerNotify.ApplyConfig(c)

1
notifier/notifier.go
View File

@ -257,6 +257,7 @@ func (n *Notifier) ApplyConfig(conf *config.Config) error {
ams.metrics = n.metrics ams.metrics = n.metrics
// The config pointer is used for the map lookup identifier. // The config pointer is used for the map lookup identifier.
// TODO Krasi - Maybe use the slice index as the reference.
amSets[fmt.Sprintf("%p", cfg)] = ams amSets[fmt.Sprintf("%p", cfg)] = ams
} }