From 819045541e6d8a35409eb74490de783234de6f2d Mon Sep 17 00:00:00 2001
From: "Matt T. Proud" <matt.proud@gmail.com>
Date: Thu, 6 Jun 2013 12:40:06 +0200
Subject: [PATCH] Code Review: Make double-drain a panic.

---
 storage/metric/tiered.go | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/storage/metric/tiered.go b/storage/metric/tiered.go
index 2dcba2284..d13f8c263 100644
--- a/storage/metric/tiered.go
+++ b/storage/metric/tiered.go
@@ -133,15 +133,11 @@ func (t *TieredStorage) Drain(drained chan<- bool) {
 
 func (t *TieredStorage) drain(drained chan<- bool) {
 	if t.state >= tieredStorageDraining {
-		drained <- true
-		return
+		panic("Illegal State: Supplemental drain requested.")
 	}
 
-	select {
-	case t.draining <- (drained):
-		log.Println("Triggering drain...")
-	default:
-	}
+	log.Println("Triggering drain...")
+	t.draining <- (drained)
 }
 
 // Enqueues a ViewRequestBuilder for materialization, subject to a timeout.