RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1892 from fstab/assume-counters-start-at-zero-after-reset 

Assume counters start at zero after reset.
This commit is contained in:
Julius Volz 2016-08-13 00:14:07 +02:00 committed by GitHub
parent fe7b8b7fd1 08b6556ee6
commit 80b0e1b74c
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
promql/functions.go
View File

@ -68,7 +68,7 @@ func extrapolatedRate(ev *evaluator, arg Expr, isCounter bool, isRate bool) mode
for _, sample := range samples.Values { for _, sample := range samples.Values {
currentValue := sample.Value currentValue := sample.Value
if isCounter && currentValue < lastValue { if isCounter && currentValue < lastValue {
counterCorrection += lastValue - currentValue counterCorrection += lastValue
} }
lastValue = currentValue lastValue = currentValue
} }

12
promql/testdata/functions.test vendored
View File

@ -69,6 +69,18 @@ eval instant at 50m increase(http_requests[100m])
clear clear
# Test for increase() with counter reset.
# When the counter is reset, it always starts at 0.
# So the sequence 3 2 (decreasing counter = reset) is interpreted the same as 3 0 1 2.
# Prometheus assumes it missed the intermediate values 0 and 1.
load 5m
http_requests{path="/foo"} 0 1 2 3 2 3 4
eval instant at 30m increase(http_requests[30m])
{path="/foo"} 7
clear
# Tests for irate(). # Tests for irate().
load 5m load 5m
http_requests{path="/foo"} 0+10x10 http_requests{path="/foo"} 0+10x10