From 78f46bcccaf7b08306e5d5482ce5306d6662db5d Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Thu, 22 Feb 2024 09:14:52 +0000 Subject: [PATCH] tsdb/wlog tests: remove unnecessary sleep check Sleep() is documented to return immediately on negative or zero input. Signed-off-by: Bryan Boreham --- tsdb/wlog/watcher_test.go | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/tsdb/wlog/watcher_test.go b/tsdb/wlog/watcher_test.go index 871640a7c..ff006cb81 100644 --- a/tsdb/wlog/watcher_test.go +++ b/tsdb/wlog/watcher_test.go @@ -59,46 +59,36 @@ type writeToMock struct { seriesLock sync.Mutex seriesSegmentIndexes map[chunks.HeadSeriesRef]int - // delay reads with a short sleep + // If nonzero, delay reads with a short sleep. delay time.Duration } func (wtm *writeToMock) Append(s []record.RefSample) bool { - if wtm.delay > 0 { - time.Sleep(wtm.delay) - } + time.Sleep(wtm.delay) wtm.samplesAppended += len(s) return true } func (wtm *writeToMock) AppendExemplars(e []record.RefExemplar) bool { - if wtm.delay > 0 { - time.Sleep(wtm.delay) - } + time.Sleep(wtm.delay) wtm.exemplarsAppended += len(e) return true } func (wtm *writeToMock) AppendHistograms(h []record.RefHistogramSample) bool { - if wtm.delay > 0 { - time.Sleep(wtm.delay) - } + time.Sleep(wtm.delay) wtm.histogramsAppended += len(h) return true } func (wtm *writeToMock) AppendFloatHistograms(fh []record.RefFloatHistogramSample) bool { - if wtm.delay > 0 { - time.Sleep(wtm.delay) - } + time.Sleep(wtm.delay) wtm.floatHistogramsAppended += len(fh) return true } func (wtm *writeToMock) StoreSeries(series []record.RefSeries, index int) { - if wtm.delay > 0 { - time.Sleep(wtm.delay) - } + time.Sleep(wtm.delay) wtm.UpdateSeriesSegment(series, index) }