RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sort NaN as the lowest value. 

Currently it ends up in a random position.
This commit is contained in:
Brian Brazil 2015-04-17 15:49:17 +01:00
parent e681a57d73
commit 6c1689f0c6
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rules/ast/functions.go
View File

@ -169,6 +169,9 @@ func (s vectorByValueHeap) Len() int {
} }
func (s vectorByValueHeap) Less(i, j int) bool { func (s vectorByValueHeap) Less(i, j int) bool {
if math.IsNaN(float64(s[i].Value)) {
return true
}
return s[i].Value < s[j].Value return s[i].Value < s[j].Value
} }

13
rules/rules_test.go
View File

@ -307,6 +307,19 @@ func TestExpressions(t *testing.T) {
`http_requests{group="canary", instance="1", job="app-server"} => 800 @[%v]`, `http_requests{group="canary", instance="1", job="app-server"} => 800 @[%v]`,
}, },
checkOrder: true, checkOrder: true,
}, {
expr: `sort(0 / round(http_requests, 400) + http_requests)`,
output: []string{
`{group="production", instance="0", job="api-server"} => NaN @[%v]`,
`{group="production", instance="1", job="api-server"} => 200 @[%v]`,
`{group="canary", instance="0", job="api-server"} => 300 @[%v]`,
`{group="canary", instance="1", job="api-server"} => 400 @[%v]`,
`{group="production", instance="0", job="app-server"} => 500 @[%v]`,
`{group="production", instance="1", job="app-server"} => 600 @[%v]`,
`{group="canary", instance="0", job="app-server"} => 700 @[%v]`,
`{group="canary", instance="1", job="app-server"} => 800 @[%v]`,
},
checkOrder: true,
}, { }, {
expr: `sort_desc(http_requests)`, expr: `sort_desc(http_requests)`,
output: []string{ output: []string{