RepoMirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus synced 2025-01-13 02:14:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exports metric for WAL write errors (#6647)

Browse Source 
* Exports metric for WAL write errors

Signed-off-by: John McBride <jpmmcbride@gmail.com>

* Correct name for counter

Signed-off-by: John McBride <jpmmcbride@gmail.com>

* Move WAL write failure to wal.go

Signed-off-by: John McBride <jpmmcbride@gmail.com>

* WAL write fail metric moved to Log for external consumers

Signed-off-by: John McBride <jpmmcbride@gmail.com>
This commit is contained in:
John McBride 2020-01-17 13:12:04 -07:00 committed by Callum Styan
parent 2aacd807b3
commit 669592a2c4
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tsdb/wal/wal.go
View File

@ -187,6 +187,7 @@ type walMetrics struct {
truncateFail prometheus.Counter truncateFail prometheus.Counter
truncateTotal prometheus.Counter truncateTotal prometheus.Counter
currentSegment prometheus.Gauge currentSegment prometheus.Gauge
writesFailed prometheus.Counter
} }
func newWALMetrics(w *WAL, r prometheus.Registerer) *walMetrics { func newWALMetrics(w *WAL, r prometheus.Registerer) *walMetrics {
@ -217,6 +218,10 @@ func newWALMetrics(w *WAL, r prometheus.Registerer) *walMetrics {
Name: "prometheus_tsdb_wal_segment_current", Name: "prometheus_tsdb_wal_segment_current",
Help: "WAL segment index that TSDB is currently writing to.", Help: "WAL segment index that TSDB is currently writing to.",
}) })
m.writesFailed = prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_tsdb_wal_writes_failed_total",
Help: "Total number of WAL writes that failed.",
})
if r != nil { if r != nil {
r.MustRegister( r.MustRegister(
@ -226,6 +231,7 @@ func newWALMetrics(w *WAL, r prometheus.Registerer) *walMetrics {
m.truncateFail, m.truncateFail,
m.truncateTotal, m.truncateTotal,
m.currentSegment, m.currentSegment,
m.writesFailed,
) )
} }
@ -575,6 +581,7 @@ func (w *WAL) Log(recs ...[]byte) error {
// a bit of extra logic here frees them from that overhead. // a bit of extra logic here frees them from that overhead.
for i, r := range recs { for i, r := range recs {
if err := w.log(r, i == len(recs)-1); err != nil { if err := w.log(r, i == len(recs)-1); err != nil {
w.metrics.writesFailed.Inc()
return err return err
} }
} }