RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary lock in loadWAL (#6107) 

Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
This commit is contained in:
Ganesh Vernekar 2019-10-08 11:17:40 +05:30 committed by GitHub
parent 895abbb7d0
commit 4dfc7a2e77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tsdb/head.go
View File

@ -331,11 +331,10 @@ func (h *Head) loadWAL(r *wal.Reader, multiRef map[uint64]uint64) (err error) {
// They are connected through a ring of channels which ensures that all sample batches // They are connected through a ring of channels which ensures that all sample batches
// read from the WAL are processed in order. // read from the WAL are processed in order.
var ( var (
wg sync.WaitGroup wg sync.WaitGroup
multiRefLock sync.Mutex n = runtime.GOMAXPROCS(0)
n = runtime.GOMAXPROCS(0) inputs = make([]chan []record.RefSample, n)
inputs = make([]chan []record.RefSample, n) outputs = make([]chan []record.RefSample, n)
outputs = make([]chan []record.RefSample, n)
) )
wg.Add(n) wg.Add(n)
@ -394,9 +393,7 @@ func (h *Head) loadWAL(r *wal.Reader, multiRef map[uint64]uint64) (err error) {
if !created { if !created {
// There's already a different ref for this series. // There's already a different ref for this series.
multiRefLock.Lock()
multiRef[s.Ref] = series.ref multiRef[s.Ref] = series.ref
multiRefLock.Unlock()
} }
if h.lastSeriesID < s.Ref { if h.lastSeriesID < s.Ref {