Unnecessary go routine spawn. (#7951)

Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
2020-09-21 18:29:03 +08:00 · 2020-09-21 18:29:03 +08:00 · 4a52faf2ae
parent 7aa5fb01bf
commit 4a52faf2ae
1 changed files with 5 additions and 7 deletions
--- a/rules/manager.go
+++ b/rules/manager.go
@ -954,14 +954,12 @@ func (m *Manager) Update(interval time.Duration, files []string, externalLabels
 				oldg.stop()
 				newg.CopyState(oldg)
 			}
-			go func() {
-				// Wait with starting evaluation until the rule manager
-				// is told to run. This is necessary to avoid running
-				// queries against a bootstrapping storage.
-				<-m.block
-				newg.run(m.opts.Context)
-			}()
 			wg.Done()
+			// Wait with starting evaluation until the rule manager
+			// is told to run. This is necessary to avoid running
+			// queries against a bootstrapping storage.
+			<-m.block
+			newg.run(m.opts.Context)
 		}(newg)
 	}