From 35c952e344139a9fbe1863c57255ba60b397f4ca Mon Sep 17 00:00:00 2001 From: gdmello Date: Tue, 29 Aug 2017 09:22:56 -0400 Subject: [PATCH] Added logging for remote storage adapter (#3106) * Added logging for remote storage adapter on startup and on any error condition during /read or /write. * CR feedback. --- .../examples/remote_storage/remote_storage_adapter/main.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/documentation/examples/remote_storage/remote_storage_adapter/main.go b/documentation/examples/remote_storage/remote_storage_adapter/main.go index 87112b596..3208d6424 100644 --- a/documentation/examples/remote_storage/remote_storage_adapter/main.go +++ b/documentation/examples/remote_storage/remote_storage_adapter/main.go @@ -179,6 +179,7 @@ func buildClients(cfg *config) ([]writer, []reader) { writers = append(writers, c) readers = append(readers, c) } + log.Info("Starting up... ") return writers, readers } @@ -186,18 +187,21 @@ func serve(addr string, writers []writer, readers []reader) error { http.HandleFunc("/write", func(w http.ResponseWriter, r *http.Request) { compressed, err := ioutil.ReadAll(r.Body) if err != nil { + log.Errorln("Read error:", err) http.Error(w, err.Error(), http.StatusInternalServerError) return } reqBuf, err := snappy.Decode(nil, compressed) if err != nil { + log.Errorln("Decode error:", err) http.Error(w, err.Error(), http.StatusBadRequest) return } var req remote.WriteRequest if err := proto.Unmarshal(reqBuf, &req); err != nil { + log.Errorln("Unmarshal error:", err) http.Error(w, err.Error(), http.StatusBadRequest) return } @@ -219,18 +223,21 @@ func serve(addr string, writers []writer, readers []reader) error { http.HandleFunc("/read", func(w http.ResponseWriter, r *http.Request) { compressed, err := ioutil.ReadAll(r.Body) if err != nil { + log.Errorln("Read error:", err) http.Error(w, err.Error(), http.StatusInternalServerError) return } reqBuf, err := snappy.Decode(nil, compressed) if err != nil { + log.Errorln("Decode error:", err) http.Error(w, err.Error(), http.StatusBadRequest) return } var req remote.ReadRequest if err := proto.Unmarshal(reqBuf, &req); err != nil { + log.Errorln("Unmarshal error:", err) http.Error(w, err.Error(), http.StatusBadRequest) return }