Merge pull request #13885 from bboreham/readable-test

[TESTS] Truncate some long test names, for readability
This commit is contained in:
Bryan Boreham 2024-04-03 16:55:14 +01:00 committed by GitHub
commit 31491eb37c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 2 deletions

View File

@ -100,7 +100,7 @@ func TestFastRegexMatcher_MatchString(t *testing.T) {
r := r
for _, v := range testValues {
v := v
t.Run(r+` on "`+v+`"`, func(t *testing.T) {
t.Run(readable(r)+` on "`+readable(v)+`"`, func(t *testing.T) {
t.Parallel()
m, err := NewFastRegexMatcher(r)
require.NoError(t, err)
@ -111,6 +111,14 @@ func TestFastRegexMatcher_MatchString(t *testing.T) {
}
}
func readable(s string) string {
const maxReadableStringLen = 40
if len(s) < maxReadableStringLen {
return s
}
return s[:maxReadableStringLen] + "..."
}
func TestOptimizeConcatRegex(t *testing.T) {
cases := []struct {
regex string

View File

@ -3696,9 +3696,17 @@ func makeInt64Pointer(val int64) *int64 {
return valp
}
func readable(s string) string {
const maxReadableStringLen = 40
if len(s) < maxReadableStringLen {
return s
}
return s[:maxReadableStringLen] + "..."
}
func TestParseExpressions(t *testing.T) {
for _, test := range testExpr {
t.Run(test.input, func(t *testing.T) {
t.Run(readable(test.input), func(t *testing.T) {
expr, err := ParseExpr(test.input)
// Unexpected errors are always caused by a bug.