From 2b49df2c61874c9c8f360cbefe0026c196ad7171 Mon Sep 17 00:00:00 2001
From: Colstuwjx <Colstuwjx@gmail.com>
Date: Tue, 15 Aug 2017 11:10:19 +0800
Subject: [PATCH] Fix target group foreach nil bug, directly return err.

---
 discovery/file/file.go                   |  6 ++++
 discovery/file/file_test.go              | 35 ++++++++++++++++--------
 discovery/file/fixtures/invalid_nil.json |  9 ++++++
 discovery/file/fixtures/invalid_nil.yml  |  5 ++++
 4 files changed, 44 insertions(+), 11 deletions(-)
 create mode 100644 discovery/file/fixtures/invalid_nil.json
 create mode 100644 discovery/file/fixtures/invalid_nil.yml

diff --git a/discovery/file/file.go b/discovery/file/file.go
index b74c6e510..137871bd9 100644
--- a/discovery/file/file.go
+++ b/discovery/file/file.go
@@ -15,6 +15,7 @@ package file
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io/ioutil"
 	"path/filepath"
@@ -256,6 +257,11 @@ func readFile(filename string) ([]*config.TargetGroup, error) {
 	}
 
 	for i, tg := range targetGroups {
+		if tg == nil {
+			err = errors.New("nil target group item found")
+			return nil, err
+		}
+
 		tg.Source = fileSource(filename, i)
 		if tg.Labels == nil {
 			tg.Labels = model.LabelSet{}
diff --git a/discovery/file/file_test.go b/discovery/file/file_test.go
index 65c53c23b..6563b6a94 100644
--- a/discovery/file/file_test.go
+++ b/discovery/file/file_test.go
@@ -29,13 +29,17 @@ import (
 )
 
 func TestFileSD(t *testing.T) {
-	defer os.Remove("fixtures/_test.yml")
-	defer os.Remove("fixtures/_test.json")
-	testFileSD(t, ".yml")
-	testFileSD(t, ".json")
+	defer os.Remove("fixtures/_test_valid.yml")
+	defer os.Remove("fixtures/_test_valid.json")
+	defer os.Remove("fixtures/_test_invalid_nil.json")
+	defer os.Remove("fixtures/_test_invalid_nil.yml")
+	testFileSD(t, "valid", ".yml", true)
+	testFileSD(t, "valid", ".json", true)
+	testFileSD(t, "invalid_nil", ".json", false)
+	testFileSD(t, "invalid_nil", ".yml", false)
 }
 
-func testFileSD(t *testing.T, ext string) {
+func testFileSD(t *testing.T, prefix, ext string, expect bool) {
 	// As interval refreshing is more of a fallback, we only want to test
 	// whether file watches work as expected.
 	var conf config.FileSDConfig
@@ -56,13 +60,13 @@ func testFileSD(t *testing.T, ext string) {
 		t.Fatalf("Unexpected target groups in file discovery: %s", tgs)
 	}
 
-	newf, err := os.Create("fixtures/_test" + ext)
+	newf, err := os.Create("fixtures/_test_" + prefix + ext)
 	if err != nil {
 		t.Fatal(err)
 	}
 	defer newf.Close()
 
-	f, err := os.Open("fixtures/valid" + ext)
+	f, err := os.Open("fixtures/" + prefix + ext)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -80,8 +84,17 @@ retry:
 	for {
 		select {
 		case <-timeout:
-			t.Fatalf("Expected new target group but got none")
+			if expect {
+				t.Fatalf("Expected new target group but got none")
+			} else {
+				// invalid type fsd should always broken down.
+				break retry
+			}
 		case tgs := <-ch:
+			if !expect {
+				t.Fatalf("Unexpected target groups %s, we expected a failure here.", tgs)
+			}
+
 			if len(tgs) != 2 {
 				continue retry // Potentially a partial write, just retry.
 			}
@@ -90,12 +103,12 @@ retry:
 			if _, ok := tg.Labels["foo"]; !ok {
 				t.Fatalf("Label not parsed")
 			}
-			if tg.String() != filepath.FromSlash(fmt.Sprintf("fixtures/_test%s:0", ext)) {
+			if tg.String() != filepath.FromSlash(fmt.Sprintf("fixtures/_test_%s%s:0", prefix, ext)) {
 				t.Fatalf("Unexpected target group %s", tg)
 			}
 
 			tg = tgs[1]
-			if tg.String() != filepath.FromSlash(fmt.Sprintf("fixtures/_test%s:1", ext)) {
+			if tg.String() != filepath.FromSlash(fmt.Sprintf("fixtures/_test_%s%s:1", prefix, ext)) {
 				t.Fatalf("Unexpected target groups %s", tg)
 			}
 			break retry
@@ -135,7 +148,7 @@ retry:
 	}
 	newf.Close()
 
-	os.Rename(newf.Name(), "fixtures/_test"+ext)
+	os.Rename(newf.Name(), "fixtures/_test_"+prefix+ext)
 
 	cancel()
 	<-drained
diff --git a/discovery/file/fixtures/invalid_nil.json b/discovery/file/fixtures/invalid_nil.json
new file mode 100644
index 000000000..0534ba48a
--- /dev/null
+++ b/discovery/file/fixtures/invalid_nil.json
@@ -0,0 +1,9 @@
+[
+    {
+        "targets": ["localhost:9090", "example.org:443"],
+        "labels": {
+            "foo": "bar"
+        }
+    },
+    null
+]
diff --git a/discovery/file/fixtures/invalid_nil.yml b/discovery/file/fixtures/invalid_nil.yml
new file mode 100644
index 000000000..761857294
--- /dev/null
+++ b/discovery/file/fixtures/invalid_nil.yml
@@ -0,0 +1,5 @@
+- targets: ['localhost:9090', 'example.org:443']
+  labels:
+    foo: bar
+
+- null