mirror of
https://github.com/prometheus/prometheus
synced 2025-01-12 01:29:43 +00:00
Explicitly add logging flags to our custom flag set
In https://github.com/prometheus/prometheus/pull/1782 , we moved to a custom flag set to avoid getting test flags into the main prometheus binary. However, that removed the logging flags, too. This commit updates the vendoring to a version of the log package that allows adding the log flags to our flag set explicitly.
This commit is contained in:
parent
e2bb136f4e
commit
25385aafcb
@ -238,6 +238,9 @@ func init() {
|
||||
&cfg.queryEngine.MaxConcurrentQueries, "query.max-concurrency", 20,
|
||||
"Maximum number of queries executed concurrently.",
|
||||
)
|
||||
|
||||
// Copy the flags from the log package into our own flag set.
|
||||
log.AddFlags(cfg.fs)
|
||||
}
|
||||
|
||||
func parse(args []string) error {
|
||||
|
14
vendor/github.com/prometheus/common/log/log.go
generated
vendored
14
vendor/github.com/prometheus/common/log/log.go
generated
vendored
@ -91,10 +91,16 @@ func (f logFormatFlag) Set(format string) error {
|
||||
}
|
||||
|
||||
func init() {
|
||||
// In order for these flags to take effect, the user of the package must call
|
||||
// flag.Parse() before logging anything.
|
||||
flag.Var(levelFlag{}, "log.level", "Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal].")
|
||||
flag.Var(logFormatFlag{}, "log.format", "If set use a syslog logger or JSON logging. Example: logger:syslog?appname=bob&local=7 or logger:stdout?json=true. Defaults to stderr.")
|
||||
AddFlags(flag.CommandLine)
|
||||
}
|
||||
|
||||
// AddFlags adds the flags used by this package to the given FlagSet. That's
|
||||
// useful if working with a custom FlagSet. The init function of this package
|
||||
// adds the flags to flag.CommandLine anyway. Thus, it's usually enough to call
|
||||
// flag.Parse() to make the logging flags take effect.
|
||||
func AddFlags(fs *flag.FlagSet) {
|
||||
fs.Var(levelFlag{}, "log.level", "Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal].")
|
||||
fs.Var(logFormatFlag{}, "log.format", "If set use a syslog logger or JSON logging. Example: logger:syslog?appname=bob&local=7 or logger:stdout?json=true. Defaults to stderr.")
|
||||
}
|
||||
|
||||
type Logger interface {
|
||||
|
6
vendor/vendor.json
vendored
6
vendor/vendor.json
vendored
@ -175,10 +175,10 @@
|
||||
"revisionTime": "2016-06-23T15:14:27Z"
|
||||
},
|
||||
{
|
||||
"checksumSHA1": "qHoBp/PVBcLedTNZrF3toV9QGa0=",
|
||||
"checksumSHA1": "fKMoxZehNhXbklRQy7lpFAVH0XY=",
|
||||
"path": "github.com/prometheus/common/log",
|
||||
"revision": "4402f4e5ea79ec15f3c574773b6a5198fbea215f",
|
||||
"revisionTime": "2016-06-23T15:14:27Z"
|
||||
"revision": "610701b0cb96fe82d0166b8e07979b174b6f06ae",
|
||||
"revisionTime": "2016-07-20T15:23:54Z"
|
||||
},
|
||||
{
|
||||
"checksumSHA1": "Jx0GXl5hGnO25s3ryyvtdWHdCpw=",
|
||||
|
Loading…
Reference in New Issue
Block a user