RepoMirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus synced 2024-12-27 00:53:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve notifier queue test to reduce flakiness (#10984)

Browse Source 
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
This commit is contained in:
Julien Pivotto 2022-07-05 15:27:26 +02:00 committed by GitHub
parent 7479cd95b0
commit 2479fb42f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
notifier/notifier_test.go
View File

@ -590,8 +590,13 @@ func TestHangingNotifier(t *testing.T) {
close(done) close(done)
}() }()
var calledOnce bool
// Setting up a bad server. This server hangs for 2 seconds. // Setting up a bad server. This server hangs for 2 seconds.
badServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { badServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if calledOnce {
t.Fatal("hanging server called multiple times")
}
calledOnce = true
select { select {
case <-done: case <-done:
case <-time.After(2 * time.Second): case <-time.After(2 * time.Second):
@ -672,8 +677,8 @@ func TestHangingNotifier(t *testing.T) {
}() }()
select { select {
case <-time.After(300 * time.Millisecond): case <-time.After(1 * time.Second):
t.Fatalf("Timeout after 300 milliseconds, targets not synced in time.") t.Fatalf("Timeout after 1 second, targets not synced in time.")
case <-changed: case <-changed:
// The good server has been hit in less than 3 seconds, therefore // The good server has been hit in less than 3 seconds, therefore
// targets have been updated before a second call could be made to the // targets have been updated before a second call could be made to the