From 23be3dab53a1815e61ba00ba6d96f112901832b5 Mon Sep 17 00:00:00 2001 From: Matti Savolainen Date: Tue, 11 Oct 2016 21:54:33 +0300 Subject: [PATCH] test label name validation --- relabel/relabel_test.go | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/relabel/relabel_test.go b/relabel/relabel_test.go index c4e4614fa..76a7ff477 100644 --- a/relabel/relabel_test.go +++ b/relabel/relabel_test.go @@ -312,7 +312,7 @@ func TestRelabel(t *testing.T) { "a": "some-name-value", }, }, - { // invalid target_label "" + { // invalid target_labels input: model.LabelSet{ "a": "some-name-value", }, @@ -324,6 +324,20 @@ func TestRelabel(t *testing.T) { Replacement: "${1}", TargetLabel: model.LabelName("${3}"), }, + { + SourceLabels: model.LabelNames{"a"}, + Regex: config.MustNewRegexp("some-([^-]+)-([^,]+)"), + Action: config.RelabelReplace, + Replacement: "${1}", + TargetLabel: model.LabelName("0${3}"), + }, + { + SourceLabels: model.LabelNames{"a"}, + Regex: config.MustNewRegexp("some-([^-]+)-([^,]+)"), + Action: config.RelabelReplace, + Replacement: "${1}", + TargetLabel: model.LabelName("-${3}"), + }, }, output: model.LabelSet{ "a": "some-name-value", @@ -353,20 +367,14 @@ func TestRelabel(t *testing.T) { Regex: config.MustNewRegexp(".*?(?:,|^)label:([^=]+)=([^,]+).*"), Action: config.RelabelReplace, Replacement: "${2}", - TargetLabel: model.LabelName("__meta_sd_add_label_${1}"), - }, - { - Regex: config.MustNewRegexp("__meta_sd_add_label_(.*)"), - Replacement: "${1}", - Action: config.RelabelLabelMap, + TargetLabel: model.LabelName("${1}"), }, }, output: model.LabelSet{ "__meta_sd_tags": "path:/secret,job:some-job,label:foo=bar", "__metrics_path__": "/secret", "job": "some-job", - "__meta_sd_add_label_foo": "bar", - "foo": "bar", + "foo": "bar", }, }, }