From 0c07663b7026f826173f2cfb1dcb42830bbd14bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Furkan=20T=C3=BCrkal?= Date: Mon, 25 Oct 2021 16:14:40 +0300 Subject: [PATCH] fix: possible race on shared variables in test (#9470) Fixes #9433 Signed-off-by: Furkan --- tsdb/db_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tsdb/db_test.go b/tsdb/db_test.go index 26ead3fc3..88342c8f8 100644 --- a/tsdb/db_test.go +++ b/tsdb/db_test.go @@ -663,6 +663,7 @@ func TestDB_SnapshotWithDelete(t *testing.T) { numSamples := int64(10) db := openTestDB(t, nil, nil) + defer func() { require.NoError(t, db.Close()) }() ctx := context.Background() app := db.Appender(ctx) @@ -700,15 +701,14 @@ Outer: require.NoError(t, os.RemoveAll(snap)) }() require.NoError(t, db.Snapshot(snap, true)) - require.NoError(t, db.Close()) // reopen DB from snapshot - db, err = Open(snap, nil, nil, nil, nil) + newDB, err := Open(snap, nil, nil, nil, nil) require.NoError(t, err) - defer func() { require.NoError(t, db.Close()) }() + defer func() { require.NoError(t, newDB.Close()) }() // Compare the result. - q, err := db.Querier(context.TODO(), 0, numSamples) + q, err := newDB.Querier(context.TODO(), 0, numSamples) require.NoError(t, err) defer func() { require.NoError(t, q.Close()) }()