From 05ca082b079bb12dc7ad0f8c3940774df803401b Mon Sep 17 00:00:00 2001 From: gotjosh Date: Tue, 30 Apr 2024 12:43:09 +0100 Subject: [PATCH] Rename `alerts` to `expectedAlerts` in the test case input Signed-off-by: gotjosh --- rules/manager_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rules/manager_test.go b/rules/manager_test.go index d74a7dfe1..07159145f 100644 --- a/rules/manager_test.go +++ b/rules/manager_test.go @@ -401,7 +401,7 @@ func TestForStateRestore(t *testing.T) { type testInput struct { name string restoreDuration time.Duration - alerts []*Alert + expectedAlerts []*Alert num int noRestore bool @@ -414,7 +414,7 @@ func TestForStateRestore(t *testing.T) { { name: "normal restore (alerts were not firing)", restoreDuration: 15 * time.Minute, - alerts: rule.ActiveAlerts(), + expectedAlerts: rule.ActiveAlerts(), downDuration: 10 * time.Minute, }, { @@ -426,12 +426,12 @@ func TestForStateRestore(t *testing.T) { { name: "no active alerts", restoreDuration: 50 * time.Minute, - alerts: []*Alert{}, + expectedAlerts: []*Alert{}, }, { name: "test the grace period", restoreDuration: 25 * time.Minute, - alerts: []*Alert{}, + expectedAlerts: []*Alert{}, gracePeriod: true, before: func() { for _, duration := range []time.Duration{10 * time.Minute, 15 * time.Minute, 20 * time.Minute} { @@ -496,7 +496,7 @@ func TestForStateRestore(t *testing.T) { require.Equal(t, opts.ForGracePeriod, e.ActiveAt.Add(alertForDuration).Sub(restoreTime)) } default: - exp := tt.alerts + exp := tt.expectedAlerts require.Equal(t, len(exp), len(got)) sortAlerts(exp) sortAlerts(got)