From 034eb2b3f2b31589ce1ebd6402e1fb6465b0afd4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Gouteroux?= <francois.gouteroux@gmail.com>
Date: Tue, 4 Apr 2023 13:28:02 +0200
Subject: [PATCH] promtool: read from stdin if no filenames are provided in
 check rules
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
---
 cmd/promtool/main.go          | 21 +++++++++++++++++----
 docs/command-line/promtool.md |  4 ++--
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/cmd/promtool/main.go b/cmd/promtool/main.go
index 064e7a04f..abac38d5f 100644
--- a/cmd/promtool/main.go
+++ b/cmd/promtool/main.go
@@ -131,8 +131,8 @@ func main() {
 	checkRulesCmd := checkCmd.Command("rules", "Check if the rule files are valid or not.")
 	ruleFiles := checkRulesCmd.Arg(
 		"rule-files",
-		"The rule files to check.",
-	).Required().ExistingFiles()
+		"The rule files to check, default is read from standard input (STDIN).",
+	).Default("-").Strings()
 	checkRulesLint := checkRulesCmd.Flag(
 		"lint",
 		"Linting checks to apply. Available options are: "+strings.Join(lintOptions, ", ")+". Use --lint=none to disable linting",
@@ -715,9 +715,22 @@ func CheckRules(ls lintConfig, files ...string) int {
 }
 
 func checkRules(filename string, lintSettings lintConfig) (int, []error) {
-	fmt.Println("Checking", filename)
+	var rgs *rulefmt.RuleGroups
+	var errs []error
+	if filename == "-" || filename == "" {
+		var buf bytes.Buffer
+		tee := io.TeeReader(os.Stdin, &buf)
+		if _, err := buf.ReadFrom(tee); err != nil {
+			errs = append(errs, err)
+			return failureExitCode, errs
+		}
+		fmt.Println("Checking stdin")
+		rgs, errs = rulefmt.Parse(buf.Bytes())
+	} else {
+		fmt.Println("Checking", filename)
+		rgs, errs = rulefmt.ParseFile(filename)
+	}
 
-	rgs, errs := rulefmt.ParseFile(filename)
 	if errs != nil {
 		return successExitCode, errs
 	}
diff --git a/docs/command-line/promtool.md b/docs/command-line/promtool.md
index 543034f15..6b67408c9 100644
--- a/docs/command-line/promtool.md
+++ b/docs/command-line/promtool.md
@@ -179,9 +179,9 @@ Check if the rule files are valid or not.
 
 ###### Arguments
 
-| Argument | Description | Required |
+| Argument | Description | Default |
 | --- | --- | --- |
-| rule-files | The rule files to check. | Yes |
+| rule-files | The rule files to check, default is read from standard input (STDIN). | `-` |