RepoMirrors
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix off-by-one bug in NewFingerprintFromMetric().

This commit is contained in:
Julius Volz 2013-04-09 02:33:17 +02:00
parent ca2a31c48b
commit 0230dbf305
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
model/fingerprinting.go
View File

@ -94,7 +94,7 @@ func NewFingerprintFromMetric(metric Metric) (f Fingerprint) {
firstCharacterOfFirstLabelName = labelName[0:1] firstCharacterOfFirstLabelName = labelName[0:1]
} }
if i == labelLength-1 { if i == labelLength-1 {
lastCharacterOfLastLabelValue = string(labelValue[labelValueLength-2 : labelValueLength-1]) lastCharacterOfLastLabelValue = string(labelValue[labelValueLength-1 : labelValueLength])
} }
summer.Write([]byte(labelName)) summer.Write([]byte(labelName))

9
model/metric_test.go
View File

@ -35,9 +35,16 @@ func testMetric(t test.Tester) {
"occupation": "robot", "occupation": "robot",
"manufacturer": "westinghouse", "manufacturer": "westinghouse",
}, },
rowkey: "04776841610193542734-f-56-o", rowkey: "04776841610193542734-f-56-t",
hash: 4776841610193542734, hash: 4776841610193542734,
}, },
{
input: map[string]string{
"x": "y",
},
rowkey: "01306929544689993150-x-2-y",
hash: 1306929544689993150,
},
} }
for i, scenario := range scenarios { for i, scenario := range scenarios {