osu/osu.Game/Online
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
API Remove using statement 2024-05-30 17:45:32 +09:00
Chat Move dialog strings to more common class name 2024-05-31 11:46:32 +09:00
Leaderboards Merge branch 'master' into LeaderBoardScore_clean 2024-06-07 22:42:49 +03:00
Metadata Add client/server models & operations for "daily challenge" feature 2024-05-17 10:58:08 +02:00
Multiplayer Fix room status not updating when password is changed while inside the room 2024-05-03 11:37:09 +02:00
Notifications/WebSocket
Placeholders
Rooms Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
Solo
Spectator Fix SpectatorClient holding references to Player 2024-04-03 17:32:02 +09:00
BeatmapDownloadTracker.cs
DevelopmentEndpointConfiguration.cs
DownloadState.cs
DownloadTracker.cs
EndpointConfiguration.cs
HubClient.cs
HubClientConnector.cs
IHubClientConnector.cs
ILinkHandler.cs
IStatefulUserHubClient.cs
OnlineStatusNotifier.cs
OnlineViewContainer.cs
PersistentEndpointClient.cs
PersistentEndpointClientConnector.cs
PollingComponent.cs
ProductionEndpointConfiguration.cs
ScoreDownloadTracker.cs
SignalRDerivedTypeWorkaroundJsonConverter.cs
SignalRUnionWorkaroundResolver.cs
SignalRWorkaroundTypes.cs
UserStatisticsUpdate.cs
UserStatisticsWatcher.cs