mirror of
https://github.com/ppy/osu
synced 2024-12-26 08:53:10 +00:00
25e38560ce
`BeatmapListingOverlay.addContentToPlaceholder()`, in order to make transitions between different beatmap listing content (whether it is actual cards, or placeholders for no beatmaps found/supporter-specific filters chosen), would set `BypassAutoSizeAxes = Y` on content as it is fading out, to make the transition smoother. The property in question was supposed to be getting restored to `None` on the next show. In testing scenarios, it sometimes turned out that this wasn't the case, therefore making the placeholders effectively not show - while they were present and fully opaque, they would be the only child of an auto-sized container with `BypassAutoSizeAxes = Y`, so the parent auto-sized to a zero height, which logically follows from the premise, but is not what was desired. This in turn was caused by the fact that the `BypassAutoSizeAxes = Y` set was scheduled, and sometimes it would be scheduled in such a way that the drawable would cease to be present on the next frame due to its alpha being past the cutoff point of 0.0001. Therefore the scheduled set would not execute until the *next* time the placeholder was shown, therefore causing the bug. Fix by ensuring that the placeholder drawables are always present if their schedulers have any tasks enqueued, on top of the usual checks of alpha and scale performed via the base implementation. |
||
|---|---|---|
| .. | ||
| AccountCreation | ||
| BeatmapListing | ||
| BeatmapSet | ||
| Changelog | ||
| Chat | ||
| Comments | ||
| Dashboard | ||
| Dialog | ||
| Login | ||
| MedalSplash | ||
| Mods | ||
| Music | ||
| News | ||
| Notifications | ||
| OSD | ||
| Profile | ||
| Rankings | ||
| Settings | ||
| Toolbar | ||
| Volume | ||
| Wiki | ||
| AccountCreationOverlay.cs | ||
| BeatmapListingOverlay.cs | ||
| BeatmapSetOverlay.cs | ||
| BreadcrumbControlOverlayHeader.cs | ||
| ChangelogOverlay.cs | ||
| ChatOverlay.cs | ||
| DashboardOverlay.cs | ||
| DialogOverlay.cs | ||
| FullscreenOverlay.cs | ||
| HoldToConfirmOverlay.cs | ||
| INamedOverlayComponent.cs | ||
| LoginOverlay.cs | ||
| MedalOverlay.cs | ||
| MusicController.cs | ||
| NewsOverlay.cs | ||
| NotificationOverlay.cs | ||
| NowPlayingOverlay.cs | ||
| OnlineOverlay.cs | ||
| OnScreenDisplay.cs | ||
| OverlayActivation.cs | ||
| OverlayColourProvider.cs | ||
| OverlayHeader.cs | ||
| OverlayHeaderBackground.cs | ||
| OverlayPanelDisplayStyleControl.cs | ||
| OverlayRulesetSelector.cs | ||
| OverlayRulesetTabItem.cs | ||
| OverlayScrollContainer.cs | ||
| OverlaySidebar.cs | ||
| OverlaySortTabControl.cs | ||
| OverlayStreamControl.cs | ||
| OverlayStreamItem.cs | ||
| OverlayTabControl.cs | ||
| OverlayTitle.cs | ||
| OverlayView.cs | ||
| RankingsOverlay.cs | ||
| RestoreDefaultValueButton.cs | ||
| SettingsOverlay.cs | ||
| SettingsPanel.cs | ||
| SettingsSubPanel.cs | ||
| SortDirection.cs | ||
| TabbableOnlineOverlay.cs | ||
| TabControlOverlayHeader.cs | ||
| UserProfileOverlay.cs | ||
| VolumeOverlay.cs | ||
| WaveOverlayContainer.cs | ||
| WikiOverlay.cs | ||